4.x-identity-insert #829
4.x-identity-insert #829
Conversation
…t have to copy too much code to SqlServerAdapter. (could be dryer if we wanted)
|
the PR does pass the original problem test.. I am not sure why its failing the other tests.. those failures aren't even close to the changes I made.. |
|
ok before I go way down the rabbit hole on why these output comparison tests are failing.. the first one I looked into(testNotEmptySnapshot in ). the difference is that the result is missing '<?php' on the first line otherwise it absolutely would have passed.. is this a known issue or something I am tripping over while working on something else (because this is not at all related to my changes to insert or bulkInsert. happy to look into them but don't want to confuse the issues as those are not what this is about. |
You don't have to worry about those failures, they are fixed on 4.x already. |
markstory
merged commit bebcee8
into
cakephp:4.x-identity-insert
added an implementation of insert and bulkInsert to the SqlServerAdapter.php.
In the new implementations they check options for 'identity_insert' = true.. if so it wraps the generated sql in the identity insert sql logic.
I also refactored AbstractAdapter, pulling the SQL generation out into protected functions that the copies pushed down to SqlServerAdapter didn't need the SQL generation logic as well.