Fix up short name to work with seeding. #868
Open
+82
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamisonbryant
requested changes
Jul 18, 2025
| @@ -39,8 +39,8 @@ protected function _getSchema(InputInterface $input, OutputInterface $output): ? | |||
|
|
|||
| if (!method_exists($connection, 'getSchemaCollection')) { | |||
| $msg = sprintf( | |||
| 'The "%s" connection is not compatible with orm caching, ' . | |||
| 'as it does not implement a "getSchemaCollection()" method.', | |||
| 'The `%s` connection is not compatible with orm caching, ' . | |||
There was a problem hiding this comment.
Suggested change
| 'The `%s` connection is not compatible with orm caching, ' . | |
| 'The `%s` connection is not compatible with ORM caching, ' . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This always bothered me.
The whole framework works with aliases (short name) without the need of the suffix.
But seeders need it.
While I can understand that they could be also called differently, the convention and normal approach would be to use
{name}Seed.
And as such I would expect it to work with
--seed MyNameetc.Also fixed some of the exception messages to proper code fencing for copy and paste.
This also links to Bake which also accepts the same short name and auto adds the suffix:
https://book.cakephp.org/migrations/4/en/index.html#seed-seeding-your-database