Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show version in CLI #2291

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Show version in CLI #2291

merged 1 commit into from
Jun 14, 2024

Conversation

MasterOdin
Copy link
Member

@MasterOdin MasterOdin commented Jun 10, 2024

Closes #2266

PR makes it so that the version will now show up in the CLI.

For people using composer to install phinx, the version is automatically fetched from the composer installation via the composer-runtime-api so that we don't need to worry about changing anything within our code per version. The only downside is that this does mean phinx relies on having composer:^2.0 installed, but given that came out 10/2020, and the version of PHP we support came out on 11/2021, I think this is a safe assumption to make. If you clone the repo, then the version will display as 0.x-dev, but I think that's fine.

For people using the phar, then that uses the git-tag placeholder that's replaced at compile time.

@MasterOdin MasterOdin force-pushed the feat-version branch 4 times, most recently from c95f110 to 4ceaa2b Compare June 10, 2024 14:59
@MasterOdin MasterOdin marked this pull request as ready for review June 10, 2024 15:13
@MasterOdin MasterOdin merged commit 6154850 into 0.x Jun 14, 2024
12 checks passed
@MasterOdin MasterOdin deleted the feat-version branch June 14, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argument --version does not display version
1 participant