Merged
Conversation
InvisibleSmiley
changed the title
MasterOdin
reviewed
Oct 17, 2024
InvisibleSmiley
commented
Oct 21, 2024
| public static function getSuffix(array $options): string | ||
| { | ||
| if ($options['name'] === self::MEMORY) { | ||
| if (($options['name'] ?? '') === self::MEMORY) { |
Contributor
Author
There was a problem hiding this comment.
This produced a notice when running tests (with error_reporting = E_ALL in php.ini)
InvisibleSmiley
commented
Oct 21, 2024
|
|
||
| <rule ref="CakePHP"/> | ||
|
|
||
| <rule ref="SlevomatCodingStandard.Namespaces.UnusedUses"> |
Contributor
Author
There was a problem hiding this comment.
The tests do not contain all necessary imports (uses) right now because without this PHPCS will complain.
I added the missing imports to MigrateTest and will leave the rest for someone else to clean up.
MasterOdin
approved these changes
Nov 18, 2024
MasterOdin
changed the title
Member
|
Thanks for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2270.
In the end I chose to copy/adapt OutputStyle::getErrorOutput as a new protected method on the abstract command rather than using SymfonyStyle because:
I also fixed the exit code for the case where no aliases exist, applying the rule "error output -> exit code 1".