This repository has been archived by the owner on Apr 8, 2021. It is now read-only.
Initial release #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
carlpulley
commented
Jan 29, 2018
•
carlpulley
commented
- Observable monitor implemented
- Docker container logging observable
- Jenkins build pipeline
- Unit testing for monitors
- Unit testing for docker container logging
- Library code configuration
- Scaladoc
- export test coverage reports in Jenkins
- deal with library evictions
- ensure docker-compose files are specified by caller (who has access to actual files in BuildInfo)
- Ready for review
1 task
carlpulley
commented
Jan 31, 2018
| @@ -0,0 +1,16 @@ | |||
| # Logging Testkit | |||
There was a problem hiding this comment.
Plan is to update this file once all of ISC-377 has been completed.
carlpulley
commented
Jan 31, 2018
| )(implicit | ||
| scheduler: Scheduler | ||
| ): Unit = { | ||
| ??? // TODO: needs implementing |
There was a problem hiding this comment.
Will be completed on ISC-379
carlpulley
commented
Jan 31, 2018
| package net.cakesolutions.testkit.logging.elasticsearch.formats | ||
|
|
||
| /** | ||
| * TODO: needs implementing |
There was a problem hiding this comment.
Will be completed on ISC-379
added 8 commits
January 31, 2018 14:57
aninhumer
reviewed
Feb 2, 2018
| import net.cakesolutions.testkit.logging.docker.DockerLogSource.ProcessTerminated | ||
| import net.cakesolutions.testkit.logging.docker.formats.LogEventFormat | ||
|
|
||
| trait BaseDockerLogSource extends LoggingSource[Json] { |
There was a problem hiding this comment.
Hmm, I considered a split like this, but constructed as a generic ProcessObservable, with a DockerLogSource based on it.
aninhumer
reviewed
Feb 2, 2018
| /** | ||
| * Primary interface method that specific logging sources will need to implement. | ||
| * | ||
| * @param id identifies the Docker container from which log events are consumed |
carlpulley
commented
Feb 7, 2018
|
|
||
| // $COVERAGE-OFF$ | ||
| object DockerLogLineSource extends DockerLogLineSource { | ||
| private val dockerLogsCmd = |
There was a problem hiding this comment.
TODO: we need to use docker compose files specified by a param here (caller will get this data via BuildInfo).
aninhumer
reviewed
Feb 7, 2018
| /** | ||
| * Utility methods for transforming between log lines and JSON log events. | ||
| */ | ||
| object LogEventFormat { |
There was a problem hiding this comment.
Is this Docker specific. If it's not, should it be in the core package? If it is, perhaps it should have a name that makes that clear?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.