reports_order for RT compliance to intended checks (#2844)

* reports_order for RT compliance to intended checks * add one check for reports order
cal-itp · Jul 31, 2023 · b139710 · b139710
1 parent 1c06920
commit b139710
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 18 deletions.
diff --git a/warehouse/macros/define_gtfs_guidelines.sql b/warehouse/macros/define_gtfs_guidelines.sql
@@ -105,7 +105,7 @@
 {% endmacro %}
 
 {% macro no_rt_validation_errors_sa() %}
-"The Service_alerts feed produces no errors in the MobilityData GTFS Realtime Validator"
+"The Service alerts feed produces no errors in the MobilityData GTFS Realtime Validator"
 {% endmacro %}
 
 {% macro trip_id_alignment() %}

diff --git a/warehouse/models/staging/gtfs_quality/_stg_gtfs_quality.yml b/warehouse/models/staging/gtfs_quality/_stg_gtfs_quality.yml
@@ -10,6 +10,11 @@ models:
           combination_of_columns:
             - check
             - feature
+      - dbt_utils.unique_combination_of_columns:
+          combination_of_columns:
+            - reports_order
+            - feature
+          where: 'reports_order IS NOT null'
     columns:
       - name: check
         tests:

diff --git a/warehouse/models/staging/gtfs_quality/stg_gtfs_quality__intended_checks.sql b/warehouse/models/staging/gtfs_quality/stg_gtfs_quality__intended_checks.sql
@@ -22,19 +22,19 @@ WITH stg_gtfs_quality__intended_checks AS (
     UNION ALL
     SELECT {{ no_expired_services() }}, {{ best_practices_alignment_schedule() }}, {{ schedule_feed() }}, false, null
     UNION ALL
-    SELECT {{ no_rt_validation_errors_vp() }}, {{ compliance_rt() }}, {{ rt_feed_vp() }}, false, null
+    SELECT {{ no_rt_validation_errors_vp() }}, {{ compliance_rt() }}, {{ rt_feed_vp() }}, false, 6
     UNION ALL
-    SELECT {{ no_rt_validation_errors_tu() }}, {{ compliance_rt() }}, {{ rt_feed_tu() }}, false, null
+    SELECT {{ no_rt_validation_errors_tu() }}, {{ compliance_rt() }}, {{ rt_feed_tu() }}, false, 7
     UNION ALL
-    SELECT {{ no_rt_validation_errors_sa() }}, {{ compliance_rt() }}, {{ rt_feed_sa() }}, false, null
+    SELECT {{ no_rt_validation_errors_sa() }}, {{ compliance_rt() }}, {{ rt_feed_sa() }}, false, 8
     UNION ALL
     SELECT {{ trip_id_alignment() }}, {{ fixed_route_completeness() }}, {{ rt_feed() }}, false, null
     UNION ALL
-    SELECT {{ feed_present_vehicle_positions() }}, {{ compliance_rt() }}, {{ rt_url_vp() }}, false, null
+    SELECT {{ feed_present_vehicle_positions() }}, {{ compliance_rt() }}, {{ rt_url_vp() }}, false, 3
     UNION ALL
-    SELECT {{ feed_present_trip_updates() }}, {{ compliance_rt() }}, {{ rt_url_tu() }}, false, null
+    SELECT {{ feed_present_trip_updates() }}, {{ compliance_rt() }}, {{ rt_url_tu() }}, false, 4
     UNION ALL
-    SELECT {{ feed_present_service_alerts() }}, {{ compliance_rt() }}, {{ rt_url_sa() }}, false, null
+    SELECT {{ feed_present_service_alerts() }}, {{ compliance_rt() }}, {{ rt_url_sa() }}, false, 5
     UNION ALL
     SELECT {{ rt_https_trip_updates() }}, {{ best_practices_alignment_rt() }}, {{ rt_url_tu() }}, false, null
     UNION ALL
@@ -98,24 +98,24 @@ WITH stg_gtfs_quality__intended_checks AS (
     UNION ALL
     SELECT {{ feed_listed_schedule() }}, {{ compliance_schedule() }}, {{ service() }}, false, 0
     UNION ALL
-    SELECT {{ feed_listed_vp() }}, {{ compliance_rt() }}, {{ service() }}, false, null
+    SELECT {{ feed_listed_vp() }}, {{ compliance_rt() }}, {{ service() }}, false, 0
     UNION ALL
-    SELECT {{ feed_listed_tu() }}, {{ compliance_rt() }}, {{ service() }}, false, null
+    SELECT {{ feed_listed_tu() }}, {{ compliance_rt() }}, {{ service() }}, false, 1
     UNION ALL
-    SELECT {{ feed_listed_sa() }}, {{ compliance_rt() }}, {{ service() }}, false, null
-    -- MANUAL CHECKS, null
+    SELECT {{ feed_listed_sa() }}, {{ compliance_rt() }}, {{ service() }}, false, 2
+    -- MANUAL CHECKS
     UNION ALL
     SELECT {{ organization_has_contact_info() }}, {{ technical_contact_availability() }}, {{ organization() }}, true, null
     UNION ALL
     SELECT {{ shapes_accurate() }}, {{ accurate_service_data() }}, {{ gtfs_dataset_schedule() }}, true, null
     UNION ALL
     SELECT {{ data_license_schedule() }}, {{ compliance_schedule() }}, {{ gtfs_dataset_schedule() }}, true, 4
     UNION ALL
-    SELECT {{ data_license_vp() }}, {{ compliance_rt() }}, {{ gtfs_dataset_vp() }}, true, null
+    SELECT {{ data_license_vp() }}, {{ compliance_rt() }}, {{ gtfs_dataset_vp() }}, true, 12
     UNION ALL
-    SELECT {{ data_license_tu() }}, {{ compliance_rt() }}, {{ gtfs_dataset_tu() }}, true, null
+    SELECT {{ data_license_tu() }}, {{ compliance_rt() }}, {{ gtfs_dataset_tu() }}, true, 13
     UNION ALL
-    SELECT {{ data_license_sa() }}, {{ compliance_rt() }}, {{ gtfs_dataset_sa() }}, true, null
+    SELECT {{ data_license_sa() }}, {{ compliance_rt() }}, {{ gtfs_dataset_sa() }}, true, 14
     UNION ALL
     SELECT {{ authentication_acceptable_schedule() }}, {{ availability_on_website() }}, {{ gtfs_dataset_schedule() }}, true, null
     UNION ALL
@@ -127,11 +127,11 @@ WITH stg_gtfs_quality__intended_checks AS (
     UNION ALL
     SELECT {{ stable_url_schedule() }}, {{ compliance_schedule() }}, {{ gtfs_dataset_schedule() }}, true, 3
     UNION ALL
-    SELECT {{ stable_url_vp() }}, {{ compliance_rt() }}, {{ gtfs_dataset_vp() }}, true, null
+    SELECT {{ stable_url_vp() }}, {{ compliance_rt() }}, {{ gtfs_dataset_vp() }}, true, 9
     UNION ALL
-    SELECT {{ stable_url_tu() }}, {{ compliance_rt() }}, {{ gtfs_dataset_tu() }}, true, null
+    SELECT {{ stable_url_tu() }}, {{ compliance_rt() }}, {{ gtfs_dataset_tu() }}, true, 10
     UNION ALL
-    SELECT {{ stable_url_sa() }}, {{ compliance_rt() }}, {{ gtfs_dataset_sa() }}, true, null
+    SELECT {{ stable_url_sa() }}, {{ compliance_rt() }}, {{ gtfs_dataset_sa() }}, true, 11
     UNION ALL
     SELECT {{ grading_scheme_v1() }}, {{ accurate_service_data() }}, {{ gtfs_dataset_schedule() }}, true, null
     UNION ALL
@@ -145,7 +145,7 @@ WITH stg_gtfs_quality__intended_checks AS (
     UNION ALL
     SELECT {{ trip_planner_schedule() }}, {{ compliance_schedule() }}, {{ service() }}, true, 5
     UNION ALL
-    SELECT {{ trip_planner_rt() }}, {{ compliance_rt() }}, {{ service() }}, true, null
+    SELECT {{ trip_planner_rt() }}, {{ compliance_rt() }}, {{ service() }}, true, 15
     UNION ALL
     SELECT {{ fixed_routes_match() }}, {{ fixed_route_completeness() }}, {{ gtfs_service_data_schedule() }}, true, null
     UNION ALL