-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring in calitp-data-analysis and remove calitp-data #2838
Conversation
0d4caa2
to
629c445
Compare
6195c8d
to
65d492c
Compare
629c445
to
23648fb
Compare
65d492c
to
cb8579a
Compare
05efcc3
to
ab21330
Compare
23648fb
to
c8d2126
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, with one question: what's the separation rationale behind removing the get_fs
call from __init__.py
in calitp_map_utils
? Just trying to reduce dependencies that stretch across different parts of the ecosystem?
Right exactly, the original |
4654972
to
cc28c80
Compare
Description
Describe your changes and why you're making them. Please include the context, motivation, and relevant dependencies.
Should merge #2837 first and rebase this one.
Brings calitp-data-analysis here and completely removes dependencies on calitp-data. Migrates any references/updates all images.
Every time I do this, it makes me think we should combine some images. :)
TODO: could be a follow-up PR, but still need to set up publishing to pypi for the 3 packages (map utils, data infra, data analysis)
Type of change
How has this been tested?
Include commands/logs/screenshots as relevant.
CI is running mypy and tests. I've testing the archiver, Airflow, and pod operators.
TODO: test jupyter
Post-merge follow-ups
Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.
Deploy new Jupyter pipeline images. Run stuff in production. Mark calitp-py repo as deprecated.