GCS Bucket Deprecation Process #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Broadly looks good. A few general suggestions:
- I think that perhaps we should say that anything that contains raw data should be archived and should not be deleted unless there is a concern that it's actively misleading or somehow "wrong", because that is non-recoverable.
- Only things that are processed artifacts theoretically recoverable from raw data should be candidates for actual deletion.
- Should we consider adding a README file in the
-deprecatedbuckets with some explanation as to what they are?
lauriemerrell
approved these changes
Jul 27, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Outlines a process to deprecate (cold-store) or delete out-of-use buckets in GCS, and makes minor linting fixes to the extant docs for dbt model deprecation.
Resolves #2841
Type of change
How has this been tested?
N/A
Post-merge follow-ups
Once the process is settled on and docs merged, somebody should lead a first round of the process in action.