Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports Update: Adds a query that produces gtfs rt and vp completeness #3424

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

vevetron
Copy link
Contributor

@vevetron vevetron commented Aug 23, 2024

Description

A query for use in reports.

Recreates:
tu completeness and vp completeness

I don't know if I need to provide tests or more descriptions, list out the variable names, etc.

It's calitp-id focused. Maybe it should be more general?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

poetry run dbt run -s +fct_daily_trip_updates_vehicle_positions_completeness
Results match the dashboards

Post-merge follow-ups

Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.

  • No action required
  • Actions required (specified below)

Copy link

Warehouse report 📦

Checks/potential follow-ups

Checks indicate the following action items may be necessary.

  • For new models, do they all have a surrogate primary key that is tested to be not-null and unique?

New models 🌱

calitp_warehouse.mart.gtfs_quality.fct_daily_trip_updates_vehicle_positions_completeness

DAG

Legend (in order of precedence)

Resource type Indicator Resolution
Large table-materialized model Orange Make the model incremental
Large model without partitioning or clustering Orange Add partitioning and/or clustering
View with more than one child Yellow Materialize as a table or incremental
Incremental Light green
Table Green
View White

@vevetron vevetron merged commit 8a26f18 into main Aug 23, 2024
4 checks passed
@vevetron vevetron deleted the sql_for_reports branch August 23, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants