Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing private datasets to be published to california_open_data portal. #3430

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

fsalemi
Copy link
Contributor

@fsalemi fsalemi commented Sep 5, 2024

Description

Preventing private datasets to be published to california_open_data portal .

Resolves #3416

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

poetry run dbt run -s +dim_gtfs_datasets_latest

18:55:39 Completed successfully
18:55:39 Done. PASS=5 WARN=0 ERROR=0 SKIP=0 TOTAL=5

Post-merge follow-ups

  • No action required
  • Actions required (specified below)

Copy link
Member

@tiffanychu90 tiffanychu90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Farhad!
I'm seeing some dbt build errors in the PR, do you know how to resolve those? Once those are resolved, you can merge!

@vevetron
Copy link
Contributor

vevetron commented Sep 9, 2024

Hey @tiffanychu90 I looked at those errors and i'm not sure why it's happening. Looks like dbt errors have been happening for a few weeks.

I'll write up a ticket.

@fsalemi fsalemi merged commit ad99827 into main Sep 9, 2024
3 of 4 checks passed
@fsalemi fsalemi deleted the private_dataset branch September 9, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable public/non-public URL field
3 participants