Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new incremental table for with-trip vehicle position message age by day #3492

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

fsalemi
Copy link
Contributor

@fsalemi fsalemi commented Oct 7, 2024

Description

Creating a new incremental table for with-trip vehicle position message age by day. A new Boolean column was added to the table which is TRUE if the vehicle is on a trip and FALSE if it is not on a trip.

Here is a sample of the result:

Screenshot 2024-10-07 152119

Resolves #3491

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

poetry run dbt run -s fct_daily_with_trip_vehicle_positions_message_age_summary.sql

Post-merge follow-ups

  • [x ] No action required
  • Actions required (specified below)

Copy link

github-actions bot commented Oct 7, 2024

Warehouse report 📦

Checks/potential follow-ups

Checks indicate the following action items may be necessary.

  • For new models, do they all have a surrogate primary key that is tested to be not-null and unique?

New models 🌱

calitp_warehouse.mart.gtfs_quality.fct_daily_with_trip_vehicle_positions_message_age_summary

DAG

Legend (in order of precedence)

Resource type Indicator Resolution
Large table-materialized model Orange Make the model incremental
Large model without partitioning or clustering Orange Add partitioning and/or clustering
View with more than one child Yellow Materialize as a table or incremental
Incremental Light green
Table Green
View White

@fsalemi
Copy link
Contributor Author

fsalemi commented Oct 7, 2024

@evansiroky Please review and let me know what you think, when you get a chance.

Copy link
Member

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be good to be able to analyze messages with vs without trips.

@fsalemi fsalemi merged commit 5348316 into main Oct 8, 2024
4 checks passed
@fsalemi fsalemi deleted the trip_vehicle_position branch October 8, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On-Trip Vehicle Position Message Age Summary by day
2 participants