Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New speedmap and speed variation maps #3548

Merged
merged 1 commit into from
Nov 14, 2024
Merged

New speedmap and speed variation maps #3548

merged 1 commit into from
Nov 14, 2024

Conversation

edasmalchi
Copy link
Member

@edasmalchi edasmalchi commented Nov 14, 2024

Description

Add two new layerType in Svelte map app to match the new rt_segment_speeds derived speedmap data schema. Improves display of speed segment info via tooltips. Old layerType from legacy speedmaps retained for now.

Required for cal-itp/data-analyses#1186

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Successfully ran locally, including actual state and speedmap geojson on GCS.

Screenshot 2024-11-13 at 18 18 33 Screenshot 2024-11-14 at 07 36 38

Post-merge follow-ups

Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.

  • No action required
  • Actions required (specified below)

Copy link

Copy link
Member

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have the netlify preview show the proposed change, but I trust that local testing will suffice for now.

@edasmalchi
Copy link
Member Author

thanks @evansiroky!

Would be nice to have the netlify preview show the proposed change, but I trust that local testing will suffice for now.

Ah yeah, it works but doesn't come with a default state to test. Adding one of the states I used to test locally does work, with netlify matching the local results: with state

@edasmalchi edasmalchi merged commit c620f9a into main Nov 14, 2024
2 checks passed
@edasmalchi edasmalchi deleted the revise-speedmap-app branch November 14, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants