Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: no need for two db access for booking pages #18525

Closed
wants to merge 2 commits into from
Closed

perf: no need for two db access for booking pages #18525

wants to merge 2 commits into from

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Jan 8, 2025 •
edited
Loading

What does this PR do?

  • perf improvements for booking pages

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Please use the latest Vercel preview and test please 🙏.

@vercel Vercel
Copy link

vercel bot commented Jan 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 11:32am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 11:32am

@graphite-app graphite-app bot requested a review from a team January 8, 2025 11:25
@dosubot dosubot bot added booking-page area: booking page, public booking page, booker performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive labels Jan 8, 2025
@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 8, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 8, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/08/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj changed the title perf: no need for two query fetches for booking pages perf: no need for two db access for booking pages Jan 8, 2025
@hbjORbj hbjORbj marked this pull request as draft January 8, 2025 12:22
@hbjORbj
Copy link
Contributor Author

hbjORbj commented Jan 8, 2025 •
edited
Loading

@hbjORbj

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

E2E results are ready!

@hbjORbj hbjORbj closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
booking-page area: booking page, public booking page, booker consumer core area: core, team members only performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbjORbj @keithwillcode