Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: edit webhook time #18549

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix: edit webhook time #18549

merged 2 commits into from
Jan 17, 2025
+13 −11

Conversation

Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented Jan 9, 2025 •
edited
Loading

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Fixes https://app.campsite.com/cal/posts/hazeaue72vsx#comment-kz63ys56jnnm

Screen.Recording.2025-01-09.at.2.50.10.PM.mov

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Create a webhook
  2. Edit that webhook and make sure "How long after the users don't show up on cal video meeting?" is only displayed when "After hosts didn't join cal video" and "After guests didn't join cal video" is selected

@graphite-app graphite-app bot requested a review from a team January 9, 2025 09:21
@Udit-takkar Udit-takkar added this to the v4.9 milestone Jan 9, 2025
@dosubot dosubot bot added webhooks area: webhooks, callback, webhook payload 🐛 bug Something isn't working labels Jan 9, 2025
@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Jan 9, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 9, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/09/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode modified the milestones: v4.9, v5.0 Jan 16, 2025
CarinaWolli
CarinaWolli approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙏

@CarinaWolli CarinaWolli enabled auto-merge (squash) January 16, 2025 17:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

E2E results are ready!

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 8:30am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 8:30am

@CarinaWolli CarinaWolli merged commit ea827eb into main Jan 17, 2025
38 checks passed
@CarinaWolli CarinaWolli deleted the fix/edit-webhook-input branch January 17, 2025 08:56
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@Udit-takkar @MuhammadAimanSulaiman
fix: edit webhook time (calcom#18549)
1338ddd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarinaWolli CarinaWolli CarinaWolli approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e webhooks area: webhooks, callback, webhook payload
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Udit-takkar @CarinaWolli @keithwillcode @PeerRich