Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Default number of recurring event occurrences should be configurable #18600

Conversation

Amit91848
Copy link
Contributor

What does this PR do?

Recording.2025-01-11.130958.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Jan 11, 2025

@Amit91848 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 11, 2025
@graphite-app graphite-app bot requested a review from a team January 11, 2025 07:45
@github-actions github-actions bot added enterprise area: enterprise, audit log, organisation, SAML, SSO Medium priority Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Jan 11, 2025
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking ✨ feature New feature or request labels Jan 11, 2025
Copy link

graphite-app bot commented Jan 11, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/11/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/11/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't we just set the recurring occurenceCount to minimum of occurenceCount, event.recurringEvent.count while occurentCount having default value 1.

  state.occurenceCount || 1,
  setOccurenceCount(Math.min(occurenceCount, event.recurringEvent.count));

Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments

@alishaz-polymath
Copy link
Member

@Amit91848 Can you please address the comments and we can then proceed to get this merged in 🙏

@dosubot dosubot bot added this to the v4.10 milestone Jan 16, 2025
@anikdhabal anikdhabal marked this pull request as draft January 22, 2025 12:35
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Feb 12, 2025
@dosubot dosubot bot modified the milestones: v4.10, v5.1 Feb 17, 2025
@github-actions github-actions bot removed the Stale label Feb 18, 2025
@anikdhabal anikdhabal marked this pull request as ready for review February 27, 2025 06:42
@anikdhabal anikdhabal enabled auto-merge (squash) February 27, 2025 06:42
Copy link
Contributor

@TusharBhatt1 TusharBhatt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the user enters cal.occurence > the max limit , it books an appointment with the exceeded number :
Here the limit was 12 , and I entered 20 , and it got booked

image

@keithwillcode keithwillcode added the core area: core, team members only label Mar 10, 2025
@dosubot dosubot bot removed this from the v5.1 milestone Mar 17, 2025
@dosubot dosubot bot added this to the v5.2 milestone Mar 17, 2025
@TusharBhatt1
Copy link
Contributor

Thanks for the PR , closing due to staleness.

auto-merge was automatically disabled March 20, 2025 04:53

Pull request was closed

@dosubot dosubot bot modified the milestone: v5.2 Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking community Created by Linear-GitHub Sync core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-5000] Default number of recurring event occurrences should be configurable
6 participants