fix: use eventType.description for calendar event description #27017
+180
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
dhairyashiil
requested changes
Jan 19, 2026
Member
dhairyashiil
left a comment
dhairyashiil
left a comment
There was a problem hiding this comment.
Could you please attach before and after videos demonstrating the behavior?
This will help us clearly verify the change.
The buildCalEventFromBooking function was incorrectly using booking.description (user's additional notes) as the calendar event description. This caused the event type description to be lost and replaced by additional notes when rescheduling or editing location. Changes: - Added description field to EventType type definition - Use eventType.description for the calendar event description field - Use booking.description as additionalNotes field - Updated tests to reflect the correct behavior This ensures getRichDescription() in CalendarManager correctly combines both the event type description AND additional notes in the calendar event, rather than using additional notes as the primary description. Fixes calcom#26695
Adds a dedicated E2E test to verify that event type descriptions are preserved after rescheduling and not overwritten by user's additional notes. The test: - Creates an event type with a description - Books the event with additional notes - Verifies calendar links contain the event type description - Reschedules the booking - Verifies the description is still preserved after reschedule Related to calcom#26695
RajeshKumar11
force-pushed
the
fix/reschedule-description-override
branch
from
a44515b to
a1ac4e2
Compare
Remove incorrect %20 to + replacement since Google Calendar links use %20 encoding for spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where rescheduling a meeting overwrites the Google Calendar event description with the user's additional note instead of preserving the original event type description.
Root Cause
The
buildCalEventFromBookingfunction inpackages/lib/buildCalEventFromBooking.tswas incorrectly usingbooking.description(which stores the user's additional notes) as the calendar eventdescriptionfield:This meant that when
getRichDescription()was called to build the calendar event content:descriptionfield (which should contain the event type description) was actually containing the user's additional notesadditionalNotesfield wasn't being setChanges
packages/lib/buildCalEventFromBooking.ts:
descriptionfield to theEventTypetype definitiondescriptionto useeventType.description(the actual event type description)additionalNotesfield usingbooking.description(the user's notes)packages/lib/tests/buildCalEventFromBooking.test.ts:
descriptionto mock eventTypedescriptionandadditionalNotesHow It Works Now
When
getRichDescription()is called in CalendarManager, it will correctly include:eventType.descriptionbooking.description(user's notes)Both sections appear in the Google Calendar event, preserving the original event type description while also showing the user's additional notes.
Test plan
yarn test packages/lib/__tests__/buildCalEventFromBooking.test.ts)E2E Test Added
Added
apps/web/playwright/reschedule-description.e2e.tsto test this specific scenario with video recording enabled.Fixes #26695