-
Notifications
You must be signed in to change notification settings - Fork 26
feat(cli): enhance --version outputs for merod cli #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The commit hash returns nothing for now, but when I run : git rev-parse --short HEAD it gives me the hash, but not with the cli, help me review if there is a reason for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dotandev, thanks for taking this up.
Can you apply the format established in the previous attempt: #1212
this patch applies to both meroctl
and merod
, so so you should host all version specific structures in a new calimero-version
crate (or a new module in calimero-primitives
works too, maybe even preferable)
I have this build error. I have tried to upgrade the lib but it totally disrupted the build. stellar_baselib::operation::Operation::invoke_host_function(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
93 | invoke_host_function_op.host_function,
| ------------------------------------- argument #1 of type `&stellar_baselib::operation::Operation` is missing
94 | auth,
| ---- unexpected argument #2 of type `std::option::Option<VecM<stellar_baselib::xdr::SorobanAuthorizationEntry, u32::MAX>>`
|
note: method defined here
pub fn invoke_host_function(
| ^^^^^^^^^^^^^^^^^^^^
help: did you mean
|
92 | stellar_baselib::operation::Operation::invoke_host_function(/* &stellar_baselib::operation::Operation */, invoke_host_function_op.host_function, None)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
For more information about this error, try `rustc --explain E0308`.
error: could not compile `soroban-client` (lib) due to 1 previous error
|
@miraclx could you please have a look at this one? :) |
without looking too deeply, there's nothing immediately obvious to me cc: @alenmestrov, maybe something is immediately obvious to you that won't be to me, but if this compiles on master, consider reverting your lockfile to the version on master, and rebuild $ git checkout master Cargo.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nearly there
can you expataite on these? and on this-- I was asked to implement it as calimero_rustc_version has that changed? |
That's not what you were asked - #1257 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's one last item pending
I didn't add the version.worskpace because it failed locally, same on CI: https://github.com/calimero-network/core/actions/runs/15534559089/job/43730538856?pr=1257 then, there's another fail in a previous CI from the SDK crate after I pulled from master: https://github.com/calimero-network/core/actions/runs/15533622123/job/43727709956?pr=1257 |
ah my bad we don't have a global version spec, we just manually unified them, you can revert to
that was due to your toolchain channel change to |
0.60 you mean? |
also, we need to update the version extraction for the release logic to pick from core/.github/workflows/release.yml Line 61 in 477610e
|
any thoughts on why the tests are failing? |
E2E tests reportProtocol: ethereum
Protocol: icp
Protocol: near
Protocol: stellar
|
Description
Attempts to resolve #1074.
This PR enhances the
--version
output of themerod
CLI by embedding richer build-time metadata, including:This improves traceability and simplifies debugging across environments with custom or unstable builds.
Test Plan
Output of
./target/debug/merod --version
after build:Documentation Update
N/A