-
Notifications
You must be signed in to change notification settings - Fork 26
feat(meroctl): support alias listing #1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meroctl): support alias listing #1276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meroctl context list
is missing
isn't that defined here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meroctl context list is missing
isn't that defined here?
I meant meroctl context alias list
context identity alias list will list all the identities and their aliases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're still missing meroctl context alias list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can relax your PartialEq
requirement by manually implementing Eq
& PartialEq
on Alias<T>
where T: !{Partial,}Eq
, and since you're changing it to a BTreeMap
we need a manual impl of {Partial,}Ord
as well
E2E tests reportProtocol: ethereum
Protocol: icp
Protocol: near
Protocol: stellar
|
[meroctl] alias listing support
Description
Meroctl now has alias listing support. fixes #1117
Test plan
Not done yet.
Documentation update
N/A