Skip to content

feat(meroctl): support alias listing #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 10, 2025

Conversation

cy4n1d3-p1x3l
Copy link
Contributor

@cy4n1d3-p1x3l cy4n1d3-p1x3l commented May 23, 2025

[meroctl] alias listing support

Description

Meroctl now has alias listing support. fixes #1117

Test plan

Not done yet.

Documentation update

N/A

Copy link
Member

@miraclx miraclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meroctl context list is missing

@cy4n1d3-p1x3l
Copy link
Contributor Author

meroctl context list is missing

isn't that defined here?

Copy link
Member

@miraclx miraclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meroctl context list is missing

isn't that defined here?

I meant meroctl context alias list

@cy4n1d3-p1x3l
Copy link
Contributor Author

meroctl context list is missing

isn't that defined here?

I meant meroctl context alias list

context identity alias list will list all the identities and their aliases
will context alias list list all the identities of the context specified?

Copy link
Member

@miraclx miraclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're still missing meroctl context alias list

Copy link
Member

@miraclx miraclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can relax your PartialEq requirement by manually implementing Eq & PartialEq on Alias<T> where T: !{Partial,}Eq, and since you're changing it to a BTreeMap we need a manual impl of {Partial,}Ord as well

@miraclx miraclx requested review from alenmestrov and fbozic June 9, 2025 19:40
Copy link

github-actions bot commented Jun 9, 2025

E2E tests report

Protocol: ethereum

Application/Step 0. app install (AllMembers) 1. ctx create 2. ctx invite-join 3. wait (Consensus) 4. call (create_new_proposal, Inviter) 5. get proposals 6. call (send_proposal_messages, Inviter) 7. wait (Broadcast) 8. call (get_proposal_messages, Invitees) 9. call (approve_proposal, Invitees) 10. verify external state
demo-blockchain-integrations
Application/Step 0. app install (AllMembers) 1. ctx create 2. alias create 3. call (set, Inviter) 4. call (get, Inviter) 5. ctx invite-join 6. wait (Consensus) 7. call (get, AllMembers) 8. call (set, Inviter) 9. wait (Broadcast) 10. call (get, AllMembers)
kv-store-test

Protocol: icp

Application/Step 0. app install (AllMembers) 1. ctx create 2. ctx invite-join 3. wait (Consensus) 4. call (create_new_proposal, Inviter) 5. get proposals 6. call (send_proposal_messages, Inviter) 7. wait (Broadcast) 8. call (get_proposal_messages, Invitees) 9. call (approve_proposal, Invitees) 10. verify external state
demo-blockchain-integrations
Application/Step 0. app install (AllMembers) 1. ctx create 2. alias create 3. call (set, Inviter) 4. call (get, Inviter) 5. ctx invite-join 6. wait (Consensus) 7. call (get, AllMembers) 8. call (set, Inviter) 9. wait (Broadcast) 10. call (get, AllMembers)
kv-store-test

Protocol: near

Application/Step 0. app install (AllMembers) 1. ctx create 2. ctx invite-join 3. wait (Consensus) 4. call (create_new_proposal, Inviter) 5. get proposals 6. call (send_proposal_messages, Inviter) 7. wait (Broadcast) 8. call (get_proposal_messages, Invitees) 9. call (approve_proposal, Invitees) 10. verify external state
demo-blockchain-integrations
Application/Step 0. app install (AllMembers) 1. ctx create 2. alias create 3. call (set, Inviter) 4. call (get, Inviter) 5. ctx invite-join 6. wait (Consensus) 7. call (get, AllMembers) 8. call (set, Inviter) 9. wait (Broadcast) 10. call (get, AllMembers)
kv-store-test

Protocol: stellar

Application/Step 0. app install (AllMembers) 1. ctx create 2. ctx invite-join 3. wait (Consensus) 4. call (create_new_proposal, Inviter) 5. get proposals 6. call (approve_proposal, Invitees) 7. verify external state 8. call (create_new_proposal, Inviter) 9. get proposals 10. call (send_proposal_messages, Inviter) 11. wait (Broadcast) 12. call (get_proposal_messages, Invitees)
demo-blockchain-integrations
Application/Step 0. app install (AllMembers) 1. ctx create 2. alias create 3. call (set, Inviter) 4. call (get, Inviter) 5. ctx invite-join 6. wait (Consensus) 7. call (get, AllMembers) 8. call (set, Inviter) 9. wait (Broadcast) 10. call (get, AllMembers)
kv-store-test

@miraclx miraclx changed the title feat(meroctl) : alias listing support to meroctl feat(meroctl): support alias listing Jun 10, 2025
@miraclx miraclx merged commit 01ab831 into calimero-network:master Jun 10, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to list aliases
3 participants