-
Notifications
You must be signed in to change notification settings - Fork 34
feat(metrics): integrate vmagent for metrics collection in fuzzy tests #1713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rtb-12
wants to merge
9
commits into
master
Choose a base branch
from
feat/fuzzy-workflow-metrics-scraping
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd Handlers fuzzy tests
- Updated fuzzy load test workflows to use short commit hashes for naming. - Improved logging in run-vmagent.sh to display process IDs for better tracking. - Enhanced setup-vmagent.sh to safely extract the vmagent binary and verify its presence, including a fallback mechanism for different archive structures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CI/CD] Add Victoria Metrics scraping to fuzzy load test workflow
Description
This PR adds Victoria Metrics (vmagent) integration to the fuzzy load test workflow, enabling automatic metrics collection from merod processes during long-running performance tests. The implementation extracts duplicated vmagent management logic into reusable scripts, significantly reducing code duplication and improving maintainability.
Key Changes:
scripts/setup-vmagent.sh: Downloads, extracts, and configures vmagent binaryscripts/run-vmagent.sh: Starts vmagent with dynamic process discovery and config reloadscripts/cleanup-vmagent.sh: Handles graceful shutdown and cleanup.github/workflows/fuzzy-load-test.ymlto use scripts,Metrics Collection:
Test plan
Documentation update
Note
Adds VictoriaMetrics vmagent-based metrics collection to the fuzzy load tests with reusable scripts and workflow integration.
scripts/setup-vmagent.sh,scripts/run-vmagent.sh,scripts/cleanup-vmagent.shto download/setup vmagent, generate static-port scrape configs with periodic reloads, and perform graceful cleanup.github/workflows/fuzzy-load-test.ymlnow sets up vmagent, runs tests with metrics collection for bothkv-storeandkv-store-with-handlers, captures start/end times and exit codes, and uploads vmagent logs/config as artifactspull_requesttrigger and reduce default duration to5minutes (noted TODO to revert)Written by Cursor Bugbot for commit 04c3710. This will update automatically on new commits. Configure here.