Fix apdu construction and chunking in MP::writeMemory (#152) #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removed the first 14 bytes (
code,flags,dataBlockStartAddr,startAddress,endAddress) from the payload construction in MP::writeMemory since these fields are already handled by the MC::writeMemory.Removed
setAddressmethod as it is no longer used in the updated implementation.Improved chunking logic in the memory write operation:
Instead of always using the maximum APDU length, the range is now capped based on the remaining data and the actual max APDU size.
Anything else you would like me to change?
Also a quick question, is the max apdu size written down somewhere in the spec, or where did you get that number from? I cant seem to find it in the spec.
Fixes #152