Skip to content

Step 6: MaskedView shimmers #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: step-5_memoisation
Choose a base branch
from
Open

Step 6: MaskedView shimmers #10

wants to merge 1 commit into from

Conversation

Xiltyn
Copy link
Collaborator

@Xiltyn Xiltyn commented Oct 4, 2022

  1. Reapplied the MaskedViewNativeShimmer pattern

mdjastrzebski
mdjastrzebski reviewed Oct 4, 2022
View reviewed changes
src/screens/Exhibitions/Exhibitions.tsx Outdated
@@ -33,7 +33,7 @@ type ItemProps = {
};

export const Exhibitions = ({}: Props) => {
const currentMode = useColorScheme();
const currentMode: 'light' | 'dark' = useColorScheme() || 'dark';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move the currentMode changes back to main, so that PR contains only code changes relevant to the exercise

@Xiltyn Xiltyn changed the base branch from step-3_lazy-tabs to step-4_lazy-tabs October 5, 2022 10:21
@Xiltyn Xiltyn force-pushed the step-6_shimmers branch 3 times, most recently from a35c905 to 7f2e087 Compare October 5, 2022 10:36
@Xiltyn Xiltyn changed the title feat: reapplied native shimmers with maskedView step 6: MaskedView shimmers Oct 5, 2022
@Xiltyn Xiltyn changed the title step 6: MaskedView shimmers Step 6: MaskedView shimmers Oct 5, 2022
@Xiltyn Xiltyn changed the base branch from step-4_lazy-tabs to step-5_memoisation October 5, 2022 11:21
@Xiltyn Xiltyn force-pushed the step-5_memoisation branch from 9de27c7 to 252657d Compare October 5, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdjastrzebski mdjastrzebski mdjastrzebski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xiltyn @mdjastrzebski