Skip to content

docs: document app.plugin.js in package.json exports #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vonovak
Copy link
Collaborator

@vonovak vonovak commented May 7, 2025

Summary

As people start using package.json exports more, it might be worth highlighting the "usual" exports people might want to have, which includes expo config plugin files (app.plugin.js).

Feel free to close if you see this being out of scope.

Thank you :)

Test plan

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I wouldn't add it here since these is the generic setup that people can copy/paste.

Let's add it as another paragraph below "The ./package.json field is used to..." to say something like, "Make sure to also add any other files that other tools may read, for example ./app.plugin.js if you provide a Expo Config plugin.

Then below that you can show code snippet for "./app.plugin.js": "./app.plugin.js" in the diff syntax.

@vonovak vonovak changed the title document app.plugin.js in package.json exports docs: document app.plugin.js in package.json exports May 7, 2025
@vonovak vonovak requested a review from satya164 May 7, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants