Revert "feat: implement window manager events (#142)" #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Jun 4, 2024
|
How does it correspond to #135? |
We need another solution, ideally something like |
matthargett
approved these changes
Jun 5, 2024
This reverts commit 899594b.
okwasniewski
force-pushed
the
revert/windowManagerEvents
branch
from
e3fa5d5 to
ae016ee
Compare
okwasniewski
added a commit
that referenced
this pull request
Jun 21, 2024
okwasniewski
added a commit
that referenced
this pull request
Jun 21, 2024
okwasniewski
added a commit
that referenced
this pull request
Jun 24, 2024
okwasniewski
added a commit
that referenced
this pull request
Jul 15, 2024
okwasniewski
added a commit
that referenced
this pull request
Jul 29, 2024
okwasniewski
added a commit
that referenced
this pull request
Jul 29, 2024
okwasniewski
added a commit
that referenced
this pull request
Jul 31, 2024
okwasniewski
added a commit
that referenced
this pull request
Aug 5, 2024
okwasniewski
added a commit
that referenced
this pull request
Aug 23, 2024
okwasniewski
added a commit
that referenced
this pull request
Aug 23, 2024
okwasniewski
added a commit
that referenced
this pull request
Aug 26, 2024
okwasniewski
added a commit
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API was not useful because you can achieve the same thing with AppState (visionOS doesn't differentiate between focused windows as I thought it does).
It never got released so I'm reverting the implementation.