Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for ornaments & dev menu trigger #149

Merged
merged 2 commits into from
Jun 10, 2024
Merged

feat: add support for ornaments & dev menu trigger #149

merged 2 commits into from
Jun 10, 2024

Conversation

okwasniewski
Copy link
Member

@okwasniewski okwasniewski commented Jun 5, 2024 •
edited
Loading

Summary:

This PR adds ornaments support. And also allows headset users to trigger dev menu while wearing the headset easily. (#17)

Now users can use ornaments (and any other SwiftUI modifiers on the root view!)

RCTMainWindow(moduleName: "RNTesterApp") { rootView in
   rootView.ornament(attachmentAnchor: .scene(.bottom)) {
      Button("Hey"){}
   }
}

simulator_screenshot_D101DA49-B497-405A-9C71-F7E4F0B9B839

Changelog:

Test Plan:

@okwasniewski okwasniewski changed the title feat: add support for ornaments feat: add support for ornaments & dev menu trigger Jun 5, 2024
@okwasniewski okwasniewski marked this pull request as ready for review June 10, 2024 08:45
@okwasniewski okwasniewski force-pushed the feat/ornaments branch 4 times, most recently from 4c95a5d to bae8821 Compare June 10, 2024 10:34
@okwasniewski okwasniewski merged commit 6901261 into main Jun 10, 2024
9 checks passed
@okwasniewski okwasniewski deleted the feat/ornaments branch June 10, 2024 11:06
okwasniewski added a commit that referenced this pull request Jun 10, 2024
@okwasniewski
feat: add support for ornaments & dev menu trigger (#149)
b66e34f 
* feat: add support for ornaments

* feat: add ornaments support to second window
okwasniewski added a commit that referenced this pull request Jun 21, 2024
@okwasniewski
feat: add support for ornaments & dev menu trigger (#149)
f504260 
* feat: add support for ornaments

* feat: add ornaments support to second window
okwasniewski added a commit that referenced this pull request Jun 21, 2024
@okwasniewski
feat: add support for ornaments & dev menu trigger (#149)
ae18490 
* feat: add support for ornaments

* feat: add ornaments support to second window
okwasniewski added a commit that referenced this pull request Jun 24, 2024
@okwasniewski
feat: add support for ornaments & dev menu trigger (#149)
93de222 
* feat: add support for ornaments

* feat: add ornaments support to second window
okwasniewski added a commit that referenced this pull request Jun 24, 2024
@okwasniewski
feat: add support for ornaments & dev menu trigger (#149)
c583333 
* feat: add support for ornaments

* feat: add ornaments support to second window
okwasniewski added a commit that referenced this pull request Jul 15, 2024
@okwasniewski
feat: add support for ornaments & dev menu trigger (#149)
97996eb 
* feat: add support for ornaments

* feat: add ornaments support to second window
okwasniewski added a commit that referenced this pull request Jul 29, 2024
@okwasniewski
feat: add support for ornaments & dev menu trigger (#149)
ddcb77a 
* feat: add support for ornaments

* feat: add ornaments support to second window
okwasniewski added a commit that referenced this pull request Jul 29, 2024
@okwasniewski
feat: add support for ornaments & dev menu trigger (#149)
87e8438 
* feat: add support for ornaments

* feat: add ornaments support to second window
okwasniewski added a commit that referenced this pull request Jul 31, 2024
@okwasniewski
feat: add support for ornaments & dev menu trigger (#149)
fcc99e9 
* feat: add support for ornaments

* feat: add ornaments support to second window
okwasniewski added a commit that referenced this pull request Aug 5, 2024
@okwasniewski
feat: add support for ornaments & dev menu trigger (#149)
b5161f7 
* feat: add support for ornaments

* feat: add ornaments support to second window
okwasniewski added a commit that referenced this pull request Aug 23, 2024
@okwasniewski
feat: add support for ornaments & dev menu trigger (#149)
9fd2552 
* feat: add support for ornaments

* feat: add ornaments support to second window
okwasniewski added a commit that referenced this pull request Aug 23, 2024
@okwasniewski
feat: add support for ornaments & dev menu trigger (#149)
63bd1f9 
* feat: add support for ornaments

* feat: add ornaments support to second window
okwasniewski added a commit that referenced this pull request Aug 26, 2024
@okwasniewski
feat: add support for ornaments & dev menu trigger (#149)
38a2837 
* feat: add support for ornaments

* feat: add ornaments support to second window
okwasniewski added a commit that referenced this pull request Aug 26, 2024
@okwasniewski
feat: add support for ornaments & dev menu trigger (#149)
2ce2d00 
* feat: add support for ornaments

* feat: add ornaments support to second window
okwasniewski added a commit that referenced this pull request Sep 11, 2024
@okwasniewski
feat: add support for ornaments & dev menu trigger (#149)
cef3fa3 
* feat: add support for ornaments

* feat: add ornaments support to second window
okwasniewski added a commit that referenced this pull request Sep 12, 2024
@okwasniewski
feat: add multi-window support (#117)
6c570a7 
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <[email protected]>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
okwasniewski added a commit that referenced this pull request Sep 16, 2024
@okwasniewski
feat: add multi-window support (#117)
49fe331 
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <[email protected]>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
okwasniewski added a commit that referenced this pull request Sep 16, 2024
@okwasniewski
feat: add multi-window support (#117)
6946e80 
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <[email protected]>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
okwasniewski added a commit that referenced this pull request Sep 17, 2024
@okwasniewski
feat: add multi-window support (#117)
d56523c 
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <[email protected]>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
okwasniewski added a commit that referenced this pull request Sep 17, 2024
@okwasniewski
feat: add multi-window support (#117)
ca46d39 
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <[email protected]>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
okwasniewski added a commit that referenced this pull request Sep 24, 2024
@okwasniewski
feat: add multi-window support (#117)
c1f684a 
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <[email protected]>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
okwasniewski added a commit that referenced this pull request Nov 18, 2024
@okwasniewski
feat: add multi-window support (#117)
7cfcd58 
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <[email protected]>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
okwasniewski added a commit that referenced this pull request Nov 18, 2024
@okwasniewski
feat: add multi-window support (#117)
dd16e36 
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <[email protected]>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
okwasniewski added a commit that referenced this pull request Nov 27, 2024
@okwasniewski
feat: add multi-window support (#117)
cac84be 
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <[email protected]>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
okwasniewski added a commit that referenced this pull request Nov 27, 2024
@okwasniewski
feat: add multi-window support (#117)
d937dd5 
* feat: add multi-window support

* feat: introduce WindowManager

fix: RCTReactViewController properly check props to update

fix: use clearColor instead of systemBackgroundColor for visionOS (#125)

feat: allow to use WindowHandlingModifier outside of RCTMainWindow

fix: deep and universal links when app is running (#140)

Co-authored-by: Thiago Brezinski <[email protected]>

fix: remove window init

feat: add support for ornaments & dev menu trigger (#149)

* feat: add support for ornaments

* feat: add ornaments support to second window

fix: allow to manually move dev menu to avoid conflicts (#150)

fix: remove unnecessary diff after upstreaming changes (#151)

Make CMake 3.29.0 as minimum required version (#155)

fix: move visionOS codegen specs, sync with upstream

chore: sync with upstream

fix: remove template

Move template to a separate repo

fix: update oot-release scripts

chore: remove unnecessary diff (#159)

fix: react-native-config

chore: sync with upstream

chore: sync with upstrteam
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@okwasniewski