Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove ignoresTopSafeArea prop #332

Merged
merged 2 commits into from
Mar 21, 2025
Merged

feat!: remove ignoresTopSafeArea prop #332

merged 2 commits into from
Mar 21, 2025

Conversation

okwasniewski
Copy link
Collaborator

PR Description

This PR fixes #323 and removes ignoresTopSafeArea, which was confusing and no longer needed.

It also makes the safe area handling the same as in JavaScript bottom tabs, especially in horizontal mode:

JS Tabs:

CleanShot 2025-03-21 at 09 41 08@2x

Native tabs:

CleanShot 2025-03-21 at 09 41 21@2x

Copy link

changeset-bot bot commented Mar 21, 2025

🦋 Changeset detected

Latest commit: fc7a3a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
react-native-bottom-tabs Minor
@bottom-tabs/expo-template Patch
@bottom-tabs/react-navigation Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@okwasniewski okwasniewski merged commit b8cbd28 into main Mar 21, 2025
7 checks passed
@okwasniewski okwasniewski deleted the feat/tvos-fixes branch March 21, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tvOS] tab bar measures are incorrect
1 participant