Feature/opensearch output #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syama666
reviewed
Jan 31, 2024
interfaces/opensearch/export.go
Outdated
|
|
||
| bi := openSearchBulkIndexerImpl{ | ||
| osClient: client, | ||
| queue: make(chan *bulkIndexerItem), |
Author
There was a problem hiding this comment.
すみません、消し忘れだったので remove しました！
syama666
reviewed
Jan 31, 2024
interfaces/opensearch/export.go
Outdated
| } | ||
| ) | ||
|
|
||
| func (o *OpenSearchImpl) ExportToOpenSearch(ctx context.Context, cs primitive.M) error { |
Collaborator
There was a problem hiding this comment.
ここのbulkってflushにも正常でリターンすると思うんですが、その場合ってsaveTokenまで走りますか？
そうなるとメモリに溜めてる最中にresume-tokenの位置が進んでいくので、仮にためてたものが正常にflushされなかった場合って欠損しませんか？
Author
There was a problem hiding this comment.
たしかに flush しなかった時に欠損してしまうので少しロジック調整します
syama666
reviewed
Feb 1, 2024
| id, err := json.Marshal(cs["_id"]) | ||
| if err != nil { | ||
| return errors.InternalServerErrorJsonMarshal.Wrap("Failed to marshal change streams json _id parameter.", err) | ||
| return false, errors.InternalServerErrorJsonMarshal.Wrap("Failed to marshal change streams json _id parameter.", err) |
Collaborator
There was a problem hiding this comment.
ここ saveRtFlags だから true が正しいのでは？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elasticsearch への output を追加しました。
環境変数 OPENSEARCH_SYNC_ENABLED で、
かを選択できるようにしています。
また、
を環境変数で制御できます。