-
Notifications
You must be signed in to change notification settings - Fork 1
resolve issue and update deployment setup #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Douglasymlai
commented
Jun 4, 2025
- Add community servers option
- Add github page deployment setting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for community-contributed servers, updates deployment settings for GitHub Pages, and revises documentation to reflect these changes.
- Introduced a new
communityServers
import and JSON file, integrating it into server listings, filtering, and sitemap generation. - Configured
gh-pages
deployment via a new script, updated workflows, and adjustednext.config.ts
for static export under/mcp
. - Overhauled README and CONTRIBUTING files to include community server guidelines and deployment instructions.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
public/servers/index.ts | Imported and exported communityServers . |
public/servers/community.json | Added template entry for community server config. |
package.json | Added deploy script and trailing comma. |
next.config.ts | Set basePath , output , and reactStrictMode . |
app/sitemap.ts | Integrated communityServers , updated URL logic. |
app/robots.ts | Enabled force-static for robots. |
app/page.tsx | Added filtering by community , wrapped in Suspense, updated badge variant and keys. |
app/api/github/route.ts | Added static caching and revalidation. |
README.zh-CN.md | Localized docs updated with community section. |
README.md | English docs updated, new badges, community section. |
CONTRIBUTING.md | New contributor guidelines including community. |
.github/workflows/setup-node/action.yml | New composite action to setup Node.js. |
.github/workflows/publish.yml | Workflow to publish to GitHub Pages. |
Comments suppressed due to low confidence (1)
app/page.tsx:133
- [nitpick] Changing the badge variant from
secondary
todefault
alters its appearance. Verify thatdefault
provides the intended styling or restore the previous variant.
variant={server.command === 'uvx' ? 'default' : server.command === 'npx' ? 'pink' : undefined}
@@ -53,19 +56,19 @@ export default function sitemap(): MetadataRoute.Sitemap { | |||
// Pages categorized by source | |||
routes.push( | |||
{ | |||
url: `${baseUrl}/servers/source/official`, | |||
url: `${baseUrl}/?filter=official`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With basePath: '/mcp'
set in next.config.ts
, generated URLs should include the /mcp
prefix. Consider using ${baseUrl}${nextConfig.basePath}/?filter=official
or adjusting baseUrl
to include the base path.
Copilot uses AI. Check for mistakes.
README.zh-CN.md
Outdated
``` | ||
### 🏢 官方提供方 | ||
添加 MCP 服务器配置至: | ||
[`/public/servers/officials.json`](./public/servers/officials.json) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path references officials.json
but the actual file is named official.json
. Update the filename in the link to match the real file.
[`/public/servers/officials.json`](./public/servers/officials.json) | |
[`/public/servers/official.json`](./public/servers/official.json) |
Copilot uses AI. Check for mistakes.
CONTRIBUTING.md
Outdated
|
||
This collaborative approach allows the community to maintain an up-to-date catalog of MCP servers. | ||
|
||
## Quicck Start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the heading: Quicck
should be Quick
.
## Quicck Start | |
## Quick Start |
Copilot uses AI. Check for mistakes.
setFilter(newFilter); | ||
|
||
// Update URL search params without navigation | ||
const params = new URLSearchParams(searchParams); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] useSearchParams
already returns a URLSearchParams
instance, so wrapping it in a new URLSearchParams
may be redundant. You can use searchParams
directly.
const params = new URLSearchParams(searchParams); | |
const params = searchParams; |
Copilot uses AI. Check for mistakes.