Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weaken lint-deny-level(trivial) #174

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Weaken lint-deny-level(trivial) #174

merged 1 commit into from
Oct 28, 2023

Conversation

Y-Nak
Copy link
Member

@Y-Nak Y-Nak commented Oct 26, 2023 •
edited
Loading

This PR weakens lint-deny-level to reduce troublesomeness in a development process, which was pointed out here.

  • Check test_all.sh is passed.
  • Fill out ## Changelog section. If the change is for only internal use, please write None to the section.

Changelog

None

strohel
strohel approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@strohel strohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you @Y-Nak.

bschwind
bschwind approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@strohel strohel merged commit 1e34b0a into cameleon-rs:main Oct 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschwind bschwind bschwind approved these changes

@strohel strohel strohel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Y-Nak @strohel @bschwind