Restrict payload bulk transfer size to be exactly equal to the image frame size #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_size2 are. But it seems that if we set the payload size to a larger value than the frames size, the trailer packet is also appended to the payload transfer. The trailer is expected to be a separate transfer though. We set the maximum transfer size to the frame size (which is effectively equal to the value of payload_final2_size1) - this guarantees that the trailer will be always received in another separate bulk transfer.
strohel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #196
I have no idea what are those
payload_final2_size1andpayload_final2_size2 are. But it seems that if we set the payload size to a larger value than the image frame size, the trailer packet is also appended to the payload transfer. The trailer is expected to be a separate transfer though. We set the maximum transfer size to the frame size (which is effectively equal to the value ofpayload_final2_size1) - this guarantees that the trailer will be always received in another separate bulk transfer.This problem could be specific to
MV-A5031MU815camera.Changelog