Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GHC 9.6 build #290

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Fix GHC 9.6 build #290

merged 2 commits into from
Sep 17, 2024

Conversation

raehik
Copy link
Collaborator

@raehik raehik commented Sep 15, 2024

Also updates Nix flake.

No code changes, only singletons package bound tweaks and import tweaks.

@raehik raehik changed the title try to permit building with GHC 9.6 Fix GHC 9.6 build Sep 15, 2024
@raehik raehik force-pushed the support-ghc96 branch 2 times, most recently from acea802 to 37d673c Compare September 15, 2024 17:22
@raehik
Copy link
Collaborator Author

raehik commented Sep 15, 2024

This adds a bunch of redundant imports for GHC <9.6. I propose this doesn't matter. I only know how to sidestep it with CPP (which is a very silly idea here). My usual solution is to add a comment on the import line so it shows up in the warning, which I've done here.

@raehik
Copy link
Collaborator Author

raehik commented Sep 17, 2024

I'm confident the new warnings are self-describing enough to merge this without any extra pairs of eyes. If you sift through the build warnings, you'll see some 8 of these:

src/Language/Fortran/Analysis/ModGraph.hs:14:1: warning: [-Wunused-imports]
    The import of ‘Control.Monad’ is redundant
      except perhaps to import instances from ‘Control.Monad’
    To import instances alone, use: import Control.Monad()
   |
14 | import Control.Monad ( forM_ ) -- required for mtl-2.3 (GHC 9.6)

We can't disable a warning for a code block. We could disable it for a module, but I don't love that.

@raehik raehik merged commit dac52c3 into master Sep 17, 2024
7 checks passed
@raehik raehik deleted the support-ghc96 branch September 17, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant