[4.5.X] Refactor DB cache management in runtests and runmigration #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvaucher
force-pushed
the
4.5.X-refactor-cachedb
branch
3 times, most recently
from
4f1457b
to
25d214d
Compare
yvaucher
changed the title
yvaucher
force-pushed
the
4.5.X-refactor-cachedb
branch
from
25d214d
to
7c8e8ff
Compare
In order to extract the DB dump from the image we want this folder to be standalone especially in the CI
yvaucher
force-pushed
the
4.5.X-refactor-cachedb
branch
from
7c8e8ff
to
d965672
Compare
|
Rebasing on top of #300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #252 for the 4.5.X branch
Gives most variables a default value making them changable with var=${var:=default}
Extract db restore and dump in a separate db.sh file.
Change (default) value for cachedb directory to make it easier to set a volume on it.
Add || true in runmigration when doing ls -v to ignore the error status and set an empty CACHED_DUMP variable.
Improve slightly the messages.
This should fix issue of renaming in bin/runmigration of the dump file name which stayed the same as the restored one. (and in worst case to an empty filename on github actions)