Disabletabpage #32
Open
Disabletabpage #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, the original autocommand for WinNew doesn't do anything. The second WinNew autocmd overrides the first one and hence g:lens#enter_disables is never set to 1. Second, if we don't want to have lens#win_enter be called. Then no WinNew autocmd already achieves that. So the current WinNew autocmd is totally redundant.
This is useful for people using different screen resolution.
As pointed out in this [comment](camspiers#12 (comment)), WinEnter autocmd failed to detect the new window properties in some situation. This commit use timer_start to delay the callback of WinEnter to ensure that the new window properties are correctly detected.
The problem is that if a window is diabled, surely we don't resize any window when we enter it. However, when we enter another window that is not disabled, now the disabled window will be resized. And when we jump back, it won't be resized back as it is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable lens for the tabpage if any window in it is disabled.
The problem is that if a window is diabled, surely we don't resize any
window when we enter it. However, when we enter another window that is
not disabled, now the disabled window will be resized. And when we jump
back, it won't be resized back as it is disabled.