-
Notifications
You must be signed in to change notification settings - Fork 21
Feature/54 Google Cloud inclusive properties-local.mk #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for this @anderskristian! I'll review this as soon as I have some time (hopefully later this week) 💪 |
0033793
to
ed63448
Compare
@falko - Can you review this when you have a chance? This moves custom configurations (such as custom region, machine type, cluster name, dns name, etc) into Please let me know what you think? If you give the 👍 , then I'll refactor azure and aws to match. |
This is required to install web modeler
ed63448
to
07c7d2e
Compare
Refactored Still need to refactore other aws profiles as well as azure profiles. |
It makes customer merge conflicts less. It makes modularity / refactoring "easier"
I have added .ignore file + improved the Google README.md file with a "sub menu" |
Anders K. Andersen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@@ -47,6 +49,24 @@ connectors: | |||
# - name: CAMUNDA_OPERATE_CLIENT_PASSWORD | |||
# value: demo | |||
|
|||
webModeler: | |||
enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great to have the ingress configuration for the Web Modeler but I'd disable it by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this file required for this PR?
Hi @anderskristian, sorry for not getting back to you earlier. I really like your proposal and recently came to the same conclusion that the configs should better be extracted from the Would you still be interested to contribute? If so we would need you to:
Cheers, |
I will still like to contribute.
|
This PR contains