Skip to content

Feature/54 Google Cloud inclusive properties-local.mk #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

anderskristian
Copy link

@anderskristian anderskristian commented May 22, 2023

This PR contains

  1. gcloud container clusters get-credentials before using kubectl.
  2. introducing properties-local.mk
  3. The properties-local.mk is "empty" with check that "project" and "region" are defined by the developer.
  4. README.md shows sequence of make steps.

@anderskristian anderskristian self-assigned this May 22, 2023
@anderskristian anderskristian requested a review from falko May 22, 2023 17:48
@upgradingdave
Copy link
Collaborator

Thanks for this @anderskristian!

I'll review this as soon as I have some time (hopefully later this week) 💪

@upgradingdave
Copy link
Collaborator

@falko - Can you review this when you have a chance?

This moves custom configurations (such as custom region, machine type, cluster name, dns name, etc) into .mk files inside a config directory.

Please let me know what you think? If you give the 👍 , then I'll refactor azure and aws to match.

@upgradingdave
Copy link
Collaborator

Refactored aws tls profile to use config directory.

Still need to refactore other aws profiles as well as azure profiles.

Anders K. Andersen added 2 commits August 16, 2023 10:32
It makes customer merge conflicts less.
It makes modularity / refactoring "easier"
@anderskristian
Copy link
Author

anderskristian commented Aug 16, 2023

I have added .ignore file + improved the Google README.md file with a "sub menu"
I really like the standardisation that @upgradingdave added above.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ upgradingdave
❌ Anders K. Andersen


Anders K. Andersen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -47,6 +49,24 @@ connectors:
# - name: CAMUNDA_OPERATE_CLIENT_PASSWORD
# value: demo

webModeler:
enabled: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to have the ingress configuration for the Web Modeler but I'd disable it by default.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file required for this PR?

@falko
Copy link
Collaborator

falko commented Apr 25, 2025

Hi @anderskristian,

sorry for not getting back to you earlier. I really like your proposal and recently came to the same conclusion that the configs should better be extracted from the Makefile in this new profile: https://github.com/camunda-community-hub/camunda-8-helm-profiles/tree/main/multi-region/dual-region

Would you still be interested to contribute? If so we would need you to:

  1. Sign the Contributor License Agreement
  2. Respond to my review questions ;-)
  3. Rebase the PR on top of the latest main branch if possible

Cheers,
Falko

@falko falko added the enhancement New feature or request label Apr 25, 2025
@anderskristian
Copy link
Author

I will still like to contribute.

  1. I have signed the Contributor License Agreement
  2. This thing is so long ago, that I have lost the touch of what's going on.
    I will accept your changes.
  3. I basically think we should redo the things from the current latest main.
    As I understand Camunda has simplified the deployment of Camunda 8.
    Therefore I cannot pin-point what to do 🧐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants