feat(variables-tab): added keyboard shortcut and tab in app-menu

Closes #4516
camunda · Nov 5, 2024 · 4cbbf6b · 4cbbf6b
1 parent 4745fb1
commit 4cbbf6b
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 3 deletions.
diff --git a/client/src/app/App.js b/client/src/app/App.js
@@ -1945,6 +1945,11 @@ export class App extends PureComponent {
       return this.emitWithTab(type, activeTab, payload);
     }
 
+    if (action === 'open-bottom-panel') {
+      const { panel } = this.state.layout;
+      return panel.open ? this.closePanel() : this.openPanel();
+    }
+
     const tab = this.tabRef.current;
 
     return tab.triggerAction(action, options);

diff --git a/client/src/app/tabs/bpmn/BpmnEditor.js b/client/src/app/tabs/bpmn/BpmnEditor.js
@@ -466,7 +466,8 @@ export class BpmnEditor extends CachedComponent {
       setColor: !!selectionLength,
       spaceTool: !inputActive,
       undo: commandStack.canUndo(),
-      zoom: true
+      zoom: true,
+      bottomPanel: true
     };
 
     // ensure backwards compatibility

diff --git a/client/src/app/tabs/bpmn/getBpmnWindowMenu.js b/client/src/app/tabs/bpmn/getBpmnWindowMenu.js
@@ -11,7 +11,8 @@
 export default function getBpmnWindowMenu(state) {
   return [
     ...getZoomEntries(state),
-    ...getPropertiesPanelEntries(state)
+    ...getPropertiesPanelEntries(state),
+    ...getBottomPanelEntries(state)
   ];
 }
 
@@ -51,3 +52,12 @@ function getPropertiesPanelEntries({ propertiesPanel }) {
     action: 'resetProperties'
   } ] : [];
 }
+
+function getBottomPanelEntries({ bottomPanel }) {
+  return bottomPanel ? [ {
+    label: 'Toggle Bottom Panel',
+    accelerator: 'CommandOrControl+B',
+    action: 'open-bottom-panel'
+  }
+  ] : [];
+}
diff --git a/client/src/app/tabs/cloud-bpmn/BpmnEditor.js b/client/src/app/tabs/cloud-bpmn/BpmnEditor.js
@@ -432,7 +432,8 @@ export class BpmnEditor extends CachedComponent {
       setColor: !!selectionLength,
       spaceTool: !inputActive,
       undo: commandStack.canUndo(),
-      zoom: true
+      zoom: true,
+      bottomPanel: true
     };
 
     // ensure backwards compatibility