feat(variables-tab): added keyboard shortcut and tab in app-menu

Closes #4516
camunda · Nov 11, 2024 · 55c6396 · 55c6396
1 parent 9daed74
commit 55c6396
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 4 deletions.
diff --git a/client/src/app/App.js b/client/src/app/App.js
@@ -1946,6 +1946,11 @@ export class App extends PureComponent {
       return this.emitWithTab(type, activeTab, payload);
     }
 
+    if (action === 'openBottomPanel') {
+      const { panel } = this.state.layout;
+      return panel.open ? this.closePanel() : this.openPanel(panel.tab);
+    }
+
     const tab = this.tabRef.current;
 
     return tab.triggerAction(action, options);

diff --git a/client/src/app/tabs/bpmn/BpmnEditor.js b/client/src/app/tabs/bpmn/BpmnEditor.js
@@ -466,7 +466,8 @@ export class BpmnEditor extends CachedComponent {
       setColor: !!selectionLength,
       spaceTool: !inputActive,
       undo: commandStack.canUndo(),
-      zoom: true
+      zoom: true,
+      bottomPanel: true
     };
 
     // ensure backwards compatibility

diff --git a/client/src/app/tabs/bpmn/getBpmnWindowMenu.js b/client/src/app/tabs/bpmn/getBpmnWindowMenu.js
@@ -11,7 +11,8 @@
 export default function getBpmnWindowMenu(state) {
   return [
     ...getZoomEntries(state),
-    ...getPropertiesPanelEntries(state)
+    ...getPropertiesPanelEntries(state),
+    ...getBottomPanelEntries()
   ];
 }
 
@@ -51,3 +52,12 @@ function getPropertiesPanelEntries({ propertiesPanel }) {
     action: 'resetProperties'
   } ] : [];
 }
+
+function getBottomPanelEntries() {
+  return [ {
+    label: 'Toggle Bottom Panel',
+    accelerator: 'CommandOrControl+B',
+    action: 'openBottomPanel'
+  }
+  ];
+}
diff --git a/client/src/app/tabs/cloud-bpmn/BpmnEditor.js b/client/src/app/tabs/cloud-bpmn/BpmnEditor.js
@@ -432,7 +432,7 @@ export class BpmnEditor extends CachedComponent {
       setColor: !!selectionLength,
       spaceTool: !inputActive,
       undo: commandStack.canUndo(),
-      zoom: true
+      zoom: true,
     };
 
     // ensure backwards compatibility

diff --git a/client/src/app/tabs/dmn/getDmnWindowMenu.js b/client/src/app/tabs/dmn/getDmnWindowMenu.js
@@ -12,7 +12,8 @@ export default function getBpmnWindowMenu(state) {
   return [
     ...getZoomEntries(state),
     ...getPropertiesPanelEntries(state),
-    ...getOverviewEntries(state)
+    ...getOverviewEntries(state),
+    ...getBottomPanelEntries()
   ];
 }
 
@@ -63,4 +64,13 @@ function getOverviewEntries({ overview }) {
     accelerator: 'CommandOrControl+Shift+P',
     action: 'resetOverview'
   } ] : [];
+}
+
+function getBottomPanelEntries() {
+  return [ {
+    label: 'Toggle Bottom Panel',
+    accelerator: 'CommandOrControl+B',
+    action: 'openBottomPanel'
+  }
+  ];
 }