Notify the release manager & slack integration improvements

[barmac]

Proposed Changes

As discussed today in the morning, we want the release manager update to be explicitly notified to the team. This allows to react early in case the new release manager is not available. The PR is aiming to achieve that.

In the boy scout rule spirit, I also unified the slack integration in this repo to use the same version tag of the action, and consistently import the secrets from the vault.

Checklist

To ensure you provided everything we need to look at your PR:

• Brief textual description of the changes present
• Visual demo attached
• Steps to try out present, i.e. using the @bpmn-io/sr tool
• Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

[nikku]

@misiekhardcore another good one for you to review.

[misiekhardcore]

LGTM, just one thing I've noticed not related to functionality - is there any naming convention for workflow job names? cause I see some names with underscores, some with dashes and some in camel case

[barmac]

Looks like there's no convention at time. How would you solve it? Is there any convention endorsed by GH?

[nikku]

How would you solve it?

I'm a fan of consistency, and would solve it using human readable labels, i.e. "Notify project channel" over "notifcyProjectChannel" or the like. GitHub allows actions to be human readable, and I'd use that.

Our conventions for workflows are that they are UPPERCASE_UNDERSCORED.

[barmac]

For the human-readable label, we can use name property. The job ID cannot have spaces. GH seems to prefer snake_case: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/using-jobs-in-a-workflow#setting-an-id-for-a-job

[barmac]

Proposal:

• keep using snake_case as in https://github.com/camunda/camunda-modeler/blob/develop/.github/workflows/RELEASE.yml
• add human-readable names if necessary

[barmac]

Proposal:

• keep using snake_case as in https://github.com/camunda/camunda-modeler/blob/develop/.github/workflows/RELEASE.yml
• add human-readable names if necessary

Implemented in a4b6c14

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[misiekhardcore]

I personally always try to add name describing the step in human readable form. What about job names themselves I don't have strong preferences as long as they are consistent

[nikku]

Love the unification, let's ensure we communicate with the team and/or check bpmn-js / diagram-js if we have clashes there.

We want to ensure that, as always, the "standard" is clearly visible on the happy path.

[nikku]

Merging this so we can build on top, i.e. with #4655.

[misiekhardcore]

maybe its a good candidate for a spring cleaning issue to standardize the naming in workflows in other repositories?

[nikku]

Yes, I'll have a quick look into diagram-js and bpmn-js, just so we have the changes in there.

[nikku]

Follow-up for core repositories:

• ci: adjust job names to snake_case bpmn-io/diagram-js#945
• ci: adjust job names to snake_case bpmn-io/bpmn-js#2254
• https://github.com/bpmn-io/bpmn-io-demo/pull/192
• ci: make job names snake_case bpmn-io/bpmn.io#207
• https://github.com/bpmn-io/internal-docs/pull/1078
• ci: turn job names to snake case bpmn-io/bpmnlint#147
• bpmn-io/bpmn-moddle@870c42a
• ci: turn job name to snake_case bpmn-io/moddle#61
• ci: turn job names to snake_case bpmn-io/moddle-xml#76
• bpmn-io/bpmn-js-token-simulation@15c4504

I also propose to unifiy our CI workflow names, cf. #4657.

Looking forward to your @barmac and @misiekhardcore thoughts.

[misiekhardcore]

I reviewed all of them and left a comment on the names changes

[barmac]

Unfortunately, the automation I built in this PR did not work correctly today: https://github.com/camunda/camunda-modeler/actions/runs/11813602874/job/32910986873
I am investigating.

[barmac]

It looks that the same output was also not handled correctly in another flow: https://github.com/camunda/camunda-modeler/actions/runs/11254745468/job/31292835752

I checked the action logs, and the release_issue seems to never set issue output:

2024-11-13T08:41:41.3945913Z ##[group]Run bpmn-io/actions/release-issue@latest
2024-11-13T08:41:41.3946581Z with:
2024-11-13T08:41:41.3947117Z   template-path: docs/.project/RELEASE_TEMPLATE.md
2024-11-13T08:41:41.3947777Z   package-path: app/package.json
2024-11-13T08:41:41.3948431Z   token: ***
2024-11-13T08:41:41.3948869Z   labels: release,ready
2024-11-13T08:41:41.3949306Z ##[endgroup]
2024-11-13T08:41:44.9624967Z Evaluate and set job outputs
2024-11-13T08:41:44.9636905Z Set output 'assignee'
2024-11-13T08:41:44.9638378Z Cleaning up orphan processes

https://github.com/camunda/camunda-modeler/actions/runs/11813602874/job/32910976873#step:3:2