Skip to content

Commit 7883d8c

Browse files
committed
Merge branch 'hotfix/v6.3.4'
2 parents c7c90b1 + 6186d69 commit 7883d8c

File tree

8 files changed

+16
-10
lines changed

8 files changed

+16
-10
lines changed

CHANGES.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changes
22

3+
## v6.3.4
4+
5+
* Bedtools 2.28.0 binary caused stack collision.
6+
* Fix R package `gam` to 1.16.1 due to change in behaviour of 1.20 (5th July 2020).
7+
38
## v6.3.3
49

510
* Singularity specific execution issue corrected

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ FROM quay.io/wtsicgp/pcap-core:5.0.5 as builder
33
USER root
44

55
# ALL tool versions used by opt-build.sh
6-
ENV VER_BEDTOOLS="2.28.0"
6+
ENV VER_BEDTOOLS="2.29.2"
77
ENV VER_VCFTOOLS="0.1.16"
88
ENV VER_BLAT="35"
99
ENV VER_CGPVCF="v2.2.1"
@@ -69,7 +69,7 @@ FROM ubuntu:16.04
6969

7070
LABEL maintainer="[email protected]" \
7171
uk.ac.sanger.cgp="Cancer, Ageing and Somatic Mutation, Wellcome Trust Sanger Institute" \
72-
version="v6.3.3" \
72+
version="v6.3.4" \
7373
description="BRASS docker"
7474

7575
RUN apt-get -yq update \

Rsupport/libInstall.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ library(devtools)
1818
options(download.file.method = "auto")
1919

2020
ipak(c("data.table"))
21-
ipak(c("gam"))
21+
install_github("cran/gam", ref="1.16.1")
2222

2323
if ( version$major == 3 && version$minor < 2 ) {
2424
install.packages("VGAM_1.0-3.tar.gz", type="source", lib=instLib, lib.loc=instLib)

build/opt-build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ fi
7878

7979
## bedtools
8080
if [ ! -e $SETUP_DIR/bedtools.success ]; then
81-
curl -sSL --retry 10 -o $INST_PATH/bin/bedtools https://github.com/arq5x/bedtools2/releases/download/v${VER_BEDTOOLS}/bedtools
81+
curl -sSL --retry 10 -o $INST_PATH/bin/bedtools https://github.com/arq5x/bedtools2/releases/download/v${VER_BEDTOOLS}/bedtools.static.binary
8282
chmod +x $INST_PATH/bin/bedtools
8383
chmod -w $INST_PATH/bin/bedtools
8484
touch $SETUP_DIR/bedtools.success

perl/bin/brassI_prep_bam.pl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,10 @@ sub run {
7676
my ($rname,$mapq,$rnext,$tlen,$seq) = (split /\t/, $r1)[2,4,6,8,9];
7777
next if($mapq < $MIN_MAPQ);
7878
next if(($rnext eq '=' || $rname eq $rnext) && abs $tlen < (length $seq) * 2);
79-
next unless(first { $rname eq $_ } @good_seqs);
80-
next unless(first { $rnext eq $_ } @good_seqs);
79+
if(defined $options->{include}) {
80+
next unless(first { $rname eq $_ } @good_seqs);
81+
next unless(first { $rnext eq $_ } @good_seqs);
82+
}
8183
my $mapq2 = (split /\t/, $r2)[4];
8284
next if($mapq2 < $MIN_MAPQ);
8385

perl/lib/Bio/Brass.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ our @EXPORT = qw(find_breakpoints find_dusty_vertices
4646
is_dusty get_isolated_bp_alignment get_isolated_bp_surrounding_region
4747
$VERSION);
4848

49-
our $VERSION = '6.3.3';
49+
our $VERSION = '6.3.4';
5050

5151
=head1 NAME
5252

perl/lib/Sanger/CGP/Brass/Implement.pm

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ sub input {
128128
$helper_threads = 6 if($helper_threads > 6);
129129

130130
my $command = _which('samtools');
131-
$command .= ' view -F 3854 -q 6 -u '.$input;
131+
$command .= ' view -F 3854 -q 6 -u '.$input.' '.join(' ', valid_seqs($options));
132132
$command .= ' | ';
133133
$command .= _which('bedtools');
134134
$command .= sprintf $BED_INTERSECT_V, 'stdin', $options->{'depth'};
@@ -139,7 +139,6 @@ sub input {
139139
$command .= "$^X ";
140140
$command .= _which('brassI_prep_bam.pl');
141141
$command .= sprintf $PREP_BAM, $input.'.bas', $rg_prefix;
142-
$command .= " -i ".join(',', valid_seqs($options));
143142
$command .= ' | ';
144143
$command .= _which('bamsort');
145144
$command .= sprintf $BAMSORT, $tmp, $index, $outbam, $outbam, $outbam, $helper_threads, $helper_threads;

setup.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
SOURCE_BLAT="https://hgwdev.gi.ucsc.edu/~kent/src/blatSrc35.zip"
3636

3737
# if issues found downgrade to 2.23.0 but can't find any use of bedtools coverage
38-
SOURCE_BEDTOOLS="https://github.com/arq5x/bedtools2/releases/download/v2.27.1/bedtools-2.27.1.tar.gz"
38+
SOURCE_BEDTOOLS="https://github.com/arq5x/bedtools2/releases/download/v2.29.2/bedtools-2.29.2.tar.gz"
3939

4040
get_distro () {
4141
EXT=""

0 commit comments

Comments
 (0)