Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any way to ignore PL in bam? #112

Open
anoronh4 opened this issue Sep 19, 2022 · 4 comments
Open

Any way to ignore PL in bam? #112

anoronh4 opened this issue Sep 19, 2022 · 4 comments

Comments

@anoronh4
Copy link

We have a few paired samples that for some reason have different platforms in each bam of a given pair. As a result we got the following error:

BAMs have different sequencing platform: ILLUMINA, ILLUMINA-NOVASEQ-6000

They are actually the same platform but the labeling is different. Based on the code Implement.pm I don't think using the -pl command line option will work. Is there any way to make brass run without rewriting the bams?

@AndyMenzies
Copy link
Contributor

I think you will have to rewrite the bam headers. Luckily samtools makes that quite easy.

Use samtools view -H to get to the text of the header, make your edit and use samtools rehead to rewrite the header to the existing bam file.

https://www.htslib.org/doc/samtools-view.html
https://www.htslib.org/doc/samtools-reheader.html

@anoronh4
Copy link
Author

anoronh4 commented Sep 20, 2022

thanks. i think an option to override this sort of check would be nice in a future release. does the given platform affect the analysis results? if not, seems like this check could be performed by the user.

@AndyMenzies
Copy link
Contributor

That depends on the difference being seen. If you are talking about Illumina X10 v's Illumina Novaseq then it probably won't make much difference. But if you are comparing Illumina to ONT data it would have a significant impact. In our internal system we tend to populate Platform with the vendor (Illumina, ONT, PacBio) not a specific sequencing machine model.

@anoronh4
Copy link
Author

anoronh4 commented Sep 26, 2022

yes, but brass doesn't behave differently whether i have ILLUMINA-WGS in both bams, or just ONT in both bams, or abcdefg right? my point is that the user should already know and account for bams coming from different platforms. For us, re-writing very large bams is very inconvenient, for storage and for re-analysis. we will have to repeat several modules of our workflow, not just brass, because this check cannot be circumvented. in any case, this is just a suggestion, but i just wanted to clarify my thinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants