Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: build global-nav with webpack #2021

Merged
merged 1 commit into from
Nov 11, 2024
Merged

chore: build global-nav with webpack #2021

merged 1 commit into from
Nov 11, 2024

Conversation

M7mdisk
Copy link
Contributor

@M7mdisk M7mdisk commented Nov 6, 2024 •
edited
Loading

Done

  • build global-nav as part of webpack to simplify CI/CD

How to QA

  • go to demo
  • make sure global nav still works fine, no warning in console

Testing

  • This PR has tests
  • No testing required (explain why): no functional changes

Issue / Card

Fixes #

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@codeEmpress1
Copy link
Contributor

LGTM!

@M7mdisk M7mdisk merged commit 473fac3 into main Nov 11, 2024
13 checks passed
@M7mdisk M7mdisk deleted the clean-up-building branch November 11, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeEmpress1 codeEmpress1 codeEmpress1 approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M7mdisk @webteam-app @codeEmpress1