Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: global nav duplication #2030

Merged
merged 2 commits into from
Nov 15, 2024
Merged

fix: global nav duplication #2030

merged 2 commits into from
Nov 15, 2024
+0 −3

Conversation

M7mdisk
Copy link
Contributor

@M7mdisk M7mdisk commented Nov 14, 2024

Done

  • Fix global nav "All canonical" duplication
  • runby: remove some console logs

How to QA

  • Go to demo
  • see All canonical only once

Testing

  • This PR has tests
  • No testing required (explain why): is bug fix

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@M7mdisk M7mdisk changed the title Wd 16893/fix global nav fix: global nav duplication Nov 14, 2024
abbiesims
abbiesims approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@abbiesims abbiesims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 nice catch with the console logs btw - my bad!

@M7mdisk M7mdisk merged commit 6f4ec42 into main Nov 15, 2024
13 checks passed
@M7mdisk M7mdisk deleted the WD-16893/fix-global-nav branch November 15, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbiesims abbiesims abbiesims approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M7mdisk @webteam-app @abbiesims