Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set SnapInstallData from CK8sConfigSpec #62

Merged
merged 21 commits into from
Oct 15, 2024
Merged

Set SnapInstallData from CK8sConfigSpec #62

merged 21 commits into from
Oct 15, 2024

Conversation

eaudetcobello
Copy link
Contributor

No description provided.

@eaudetcobello eaudetcobello requested a review from a team as a code owner October 1, 2024 19:31
Base automatically changed from KU-1208/in-place-compatibility to main October 3, 2024 07:16
HomayoonAlimohammadi
HomayoonAlimohammadi reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this needs to be rebased, right? #61

bschimke95
bschimke95 reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first pass @eaudetcobello
looking good.

bootstrap/api/v1beta2/ck8sconfig_types.go Show resolved Hide resolved
bootstrap/controllers/ck8sconfig_controller.go Outdated Show resolved Hide resolved
bootstrap/controllers/ck8sconfig_controller.go Outdated Show resolved Hide resolved
bootstrap/controllers/ck8sconfig_controller.go Show resolved Hide resolved
bootstrap/controllers/ck8sconfig_controller.go Outdated Show resolved Hide resolved
controlplane/controllers/ck8scontrolplane_controller.go Outdated Show resolved Hide resolved
berkayoz
berkayoz reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, left some comments.

bootstrap/api/v1beta2/ck8sconfig_types.go Outdated Show resolved Hide resolved
pkg/cloudinit/scripts/install.sh Outdated Show resolved Hide resolved
controlplane/controllers/ck8scontrolplane_controller.go Outdated Show resolved Hide resolved
HomayoonAlimohammadi
HomayoonAlimohammadi reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @eaudetcobello! Great work! Almost LGTM. Just some minor comments.

bootstrap/api/v1beta2/ck8sconfig_types.go Show resolved Hide resolved
bootstrap/controllers/ck8sconfig_controller.go Outdated Show resolved Hide resolved
bschimke95
bschimke95 reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing to add to Hues comments

HomayoonAlimohammadi
HomayoonAlimohammadi approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks a lot @eaudetcobello!

@eaudetcobello eaudetcobello merged commit e55ca45 into main Oct 15, 2024
7 checks passed
@eaudetcobello eaudetcobello deleted the KU-1610/snap-track-spec branch October 15, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschimke95 bschimke95 bschimke95 left review comments

@berkayoz berkayoz berkayoz left review comments

@HomayoonAlimohammadi HomayoonAlimohammadi HomayoonAlimohammadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eaudetcobello @berkayoz @HomayoonAlimohammadi @bschimke95