Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unittest for /pkg/upgrade #78

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Add unittest for /pkg/upgrade #78

merged 5 commits into from
Nov 5, 2024

Conversation

maci3jka
Copy link
Contributor

This pr introduces unit tests for pkg/upgrade/inplace package
KU-1891

HomayoonAlimohammadi
HomayoonAlimohammadi approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @maci3jka, LGTM! Just some minor comments.

pkg/upgrade/inplace/inplace_test.go Show resolved Hide resolved
pkg/upgrade/inplace/inplace_test.go Outdated Show resolved Hide resolved
@maci3jka maci3jka marked this pull request as ready for review November 1, 2024 09:43
@maci3jka maci3jka requested a review from a team as a code owner November 1, 2024 09:43
@maci3jka maci3jka force-pushed the KU-1891/tests-for-upgrade-inplace branch from ff5e3e8 to 64ca7e8 Compare November 5, 2024 07:50
@maci3jka maci3jka merged commit 195e1fe into main Nov 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HomayoonAlimohammadi HomayoonAlimohammadi HomayoonAlimohammadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maci3jka @HomayoonAlimohammadi