fix: add missing dependency (pylibjuju)#120
fix: add missing dependency (pylibjuju)#120tonyandrewmeyer wants to merge 1 commit intocanonical:mainfrom
Conversation
23fc6fb to
f5a9071
Compare
shayancanonical
left a comment
There was a problem hiding this comment.
TIL: tox env var substitutions. LGTM!
deusebio
left a comment
There was a problem hiding this comment.
Looks good! I would just update the reference to the juju to something more recent than 2.9.x
It's the same as you have for your integration tests (I assumed you'd want it to match), but happy to change it to whatever you'd prefer. |
|
We tests a number of versions, among which 2.9.42.4 which is the oldest. I would just keep on testing on CI on that one, but I would move the default reference to latest, e.g. 3.5.0.0. Otherwise the reference would already seem out of date. I don't think that should break anything, transitive dependencies included in tox.ini are not resolved in charmlib anyway... :D |
a75c82a to
b322293
Compare
The tests use importlib.metadata to get the installed version of pylibjuju (tests/conftest.py):
However, pylibjuju is not installed as part of the requirements. This means that all tests fail with an error like:
This is fixed by installing pylibjuju for the unit environment as well as integration. Alternatively, the
version("juju")could be wrapped in a try/except, and you could fall back to a hard-coded version?