Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rockcraft file #1

Merged
merged 7 commits into from
Jul 19, 2024
Merged

rockcraft file #1

merged 7 commits into from
Jul 19, 2024

Conversation

maci3jka
Copy link
Collaborator

KU-1064

@maci3jka maci3jka requested a review from berkayoz July 10, 2024 13:06
@maci3jka maci3jka requested review from bschimke95 and a team July 15, 2024 11:28
@maci3jka maci3jka marked this pull request as ready for review July 15, 2024 11:28
bschimke95
bschimke95 reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first iteration, great work so far

rockcraft.yaml Outdated Show resolved Hide resolved
rockcraft.yaml Outdated Show resolved Hide resolved
tests/integration/conftest.py Outdated Show resolved Hide resolved
berkayoz
berkayoz reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, left some comments and questions

rockcraft.yaml Outdated Show resolved Hide resolved
tests/templates/cert-manager-test.yaml Outdated Show resolved Hide resolved
tests/integration/test_fluent_bit.py Outdated Show resolved Hide resolved
@maci3jka maci3jka mentioned this pull request Jul 19, 2024
Open
berkayoz
berkayoz approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@claudiubelu claudiubelu mentioned this pull request Jul 19, 2024
Merged
bschimke95
bschimke95 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschimke95 bschimke95 merged commit efdf34b into main Jul 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiubelu claudiubelu claudiubelu left review comments

@bschimke95 bschimke95 bschimke95 approved these changes

@berkayoz berkayoz berkayoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maci3jka @claudiubelu @berkayoz @bschimke95