Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the doc and config file #4

Merged
merged 1 commit into from
Jan 26, 2024
Merged

chore: update the doc and config file #4

merged 1 commit into from
Jan 26, 2024

Conversation

wood-push-melon
Copy link
Contributor

@wood-push-melon wood-push-melon commented Jan 25, 2024

This pull request updates docs

@wood-push-melon wood-push-melon requested a review from a team as a code owner January 25, 2024 00:03
@shipperizer
Copy link
Contributor

albeit this is technically a reasonable thing to do I'm not sure it s the best one

i would expect that if I run the rock without anything it starts up and gives me a minimum working glauth server, is that the case if we remove the config? can glauth start without a config file?

@wood-push-melon
Copy link
Contributor Author

albeit this is technically a reasonable thing to do I'm not sure it s the best one

i would expect that if I run the rock without anything it starts up and gives me a minimum working glauth server, is that the case if we remove the config? can glauth start without a config file?

Nope. If we purely run the container without mounting a config file, it will not start the service. The reason I removed it is that the charm no longer needs it and we have to maintain a copy of the config file (If something is changed in the upstream for the config, we have to remember to come here to check and modify it if needed.)

@shipperizer
Copy link
Contributor

albeit this is technically a reasonable thing to do I'm not sure it s the best one
i would expect that if I run the rock without anything it starts up and gives me a minimum working glauth server, is that the case if we remove the config? can glauth start without a config file?

Nope. If we purely run the container without mounting a config file, it will not start the service. The reason I removed it is that the charm no longer needs it and we have to maintain a copy of the config file (If something is changed in the upstream for the config, we have to remember to come here to check and modify it if needed.)

i would proabably keep it then, we are supposed to build off a tag or specific commit, so on source change we would have to double check the config

happy to go with whatever the team decides though, let's discuss at standup

@shipperizer shipperizer changed the title chore: update the doc and remove unnecessary config file chore: update the doc and config file Jan 26, 2024
@shipperizer shipperizer merged commit 4e34090 into main Jan 26, 2024
@shipperizer shipperizer deleted the doc branch January 26, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants