Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration: work around controller perms/caps issues. #8

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

aznashwan
Copy link
Contributor

This patch includes adaptations to the controller rockcraft specs
and integrations tests necessary to work around permissions/capabilities
issues which prevented the controller to be run as a non-root user.

Notable changes include:

  • the addition of a /pebble-entrypoint.sh script which runs ldconfig
    prior to exec-ing the actual entrypoint of the ROCK.
  • overriding the securityContext of the controller containers in the
    Helm chart used for integration testing.
  • pre-creation of some empty directories which are normally
    externally-mounted.

Signed-off-by: Nashwan Azhari [email protected]

aznashwan and others added 2 commits August 20, 2024 21:01
This patch includes adaptations to the controller rockcraft specs
and integrations tests necessary to work around permissions/capabilities
issues which prevented the controller to be run as a non-root user.

Notable changes include:
* the addition of a `/pebble-entrypoint.sh` script which runs `ldconfig`
  prior to exec-ing the actual entrypoint of the ROCK.
* overriding the securityContext of the controller containers in the
  Helm chart used for integration testing.
* pre-creation of some empty directories which are normally
  externally-mounted.

Signed-off-by: Nashwan Azhari <[email protected]>
Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a minor typo

README.md Outdated Show resolved Hide resolved
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berkayoz berkayoz merged commit b4ce1fd into main Sep 27, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants