-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonobuoy e2e nigthly tests #715
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going in the right direction - a couple of comments
Please add the |
|
I see that the test is marked as succeeded but the sonobouy test failed:
The Ci job should fail if the underlying test fails. No one will look at the reports if the do not fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please remove the pull_request
marker now, then we can merge this.
Great work!
on moonray only two test failed https://github.com/canonical/k8s-snap/actions/runs/11323063651/job/31484966495?pr=715 |
As written in MM: those tests fail for a reason (non-multinode cluster). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going in the right direction
# Conflicts: # .github/workflows/nightly-test.yaml # tests/integration/tests/test_util/config.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, final nit then we can merge this.
Once the tests pass ofc. |
84fe503
to
68e7004
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the test @maci3jka , please have a look at my comments.
This pr introduces Sonobuoy end-to-end test for canonical Kubernetes.