Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonobuoy e2e nigthly tests #715

Draft
wants to merge 64 commits into
base: main
Choose a base branch
from
Draft

Sonobuoy e2e nigthly tests #715

wants to merge 64 commits into from

Conversation

maci3jka
Copy link
Contributor

@maci3jka maci3jka commented Oct 7, 2024 •
edited
Loading

This pr introduces Sonobuoy end-to-end test for canonical Kubernetes.

@maci3jka maci3jka requested a review from a team as a code owner October 7, 2024 08:32
bschimke95
bschimke95 reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going in the right direction - a couple of comments

.github/workflows/sonobuoy-test.yaml Outdated Show resolved Hide resolved
.github/workflows/sonobuoy-test.yaml Outdated Show resolved Hide resolved
@bschimke95
Copy link
Contributor

Please add the pull_request tag to the workflow, so that we can see that the test actually runs and passes (to be removed before merging).

@maci3jka
Copy link
Contributor Author

maci3jka commented Oct 7, 2024

Please add the pull_request tag to the workflow, so that we can see that the test actually runs and passes (to be removed before merging).
here's build
https://github.com/canonical/k8s-snap/actions/runs/11218620215/job/31182795421?pr=715

@bschimke95
Copy link
Contributor

I see that the test is marked as succeeded but the sonobouy test failed:

17:00:17       e2e   global   complete   failed   Passed:  0, Failed:  0, Remaining:402
17:00:17 Sonobuoy has completed. Use `sonobuoy retrieve` to get results.
sonobuoy_e2e.tar.gz
Plugin: e2e
Status: failed
Total: 6607
Passed: 398
Failed: 8
Skipped: 6201

Failed tests:
 [sig-network] Services should have session affinity work for NodePort service [LinuxOnly] [Conformance]
 [sig-network] HostPort validates that there is no conflict between pods with same hostPort but different hostIP and protocol [LinuxOnly] [Conformance]
 [sig-network] Services should be able to switch session affinity for NodePort service [LinuxOnly] [Conformance]
 [sig-apps] Daemon set [Serial] should rollback without unnecessary restarts [Conformance]
 [sig-architecture] Conformance Tests should have at least two untainted nodes [Conformance]
 [sig-network] Services should be able to switch session affinity for service with type clusterIP [LinuxOnly] [Conformance]
 [sig-network] Services should serve endpoints on same port and different protocols [Conformance]
 [sig-network] Services should have session affinity work for service with type clusterIP [LinuxOnly] [Conformance]

The Ci job should fail if the underlying test fails. No one will look at the reports if the do not fail.

bschimke95
bschimke95 reviewed Oct 11, 2024
View reviewed changes
.github/workflows/cncf-conformance-test.yaml Outdated Show resolved Hide resolved
.github/workflows/cncf-conformance-test.yaml Outdated Show resolved Hide resolved
.github/workflows/cncf-conformance-test.yaml Outdated Show resolved Hide resolved
bschimke95
bschimke95 reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please remove the pull_request marker now, then we can merge this.
Great work!

.github/workflows/cncf-conformance-test.yaml Outdated Show resolved Hide resolved
@maci3jka
Copy link
Contributor Author

on moonray only two test failed https://github.com/canonical/k8s-snap/actions/runs/11323063651/job/31484966495?pr=715

@bschimke95
Copy link
Contributor

As written in MM: those tests fail for a reason (non-multinode cluster).
Please resolve this issue before removing it from the pull request run.

bschimke95
bschimke95 reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, final nit then we can merge this.

tests/integration/tox.ini Outdated Show resolved Hide resolved
@bschimke95
Copy link
Contributor

Once the tests pass ofc.

maci3jka
maci3jka commented Oct 24, 2024
View reviewed changes
tests/integration/tox.ini Outdated Show resolved Hide resolved
@maci3jka maci3jka mentioned this pull request Nov 6, 2024
Draft
louiseschmidtgen
louiseschmidtgen reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test @maci3jka , please have a look at my comments.

tests/integration/tests/test_util/config.py Outdated Show resolved Hide resolved
tests/integration/tests/test_cncf_conformace.py Outdated Show resolved Hide resolved
tests/integration/tests/test_cncf_conformace.py Show resolved Hide resolved
k8s/hack/network-requirements.sh Outdated Show resolved Hide resolved
tests/integration/tests/test_clustering.py Outdated Show resolved Hide resolved
.github/workflows/nightly-test.yaml Outdated Show resolved Hide resolved
.github/workflows/nightly-test.yaml Outdated Show resolved Hide resolved
.github/workflows/nightly-test.yaml Outdated Show resolved Hide resolved
tests/integration/tests/test_util/config.py Outdated Show resolved Hide resolved
@maci3jka maci3jka marked this pull request as draft November 8, 2024 09:33
@maci3jka maci3jka added the documentation Improvements or additions to documentation label Nov 8, 2024
@maci3jka maci3jka removed the documentation Improvements or additions to documentation label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louiseschmidtgen louiseschmidtgen Awaiting requested review from louiseschmidtgen

@bschimke95 bschimke95 Awaiting requested review from bschimke95

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maci3jka @bschimke95 @louiseschmidtgen