Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Actually include the UE binary #3

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: Actually include the UE binary #3

merged 1 commit into from
Sep 6, 2024

Conversation

ghislainbourgeois
Copy link
Collaborator

Description

The original PR did not build the UE binary, so it was missing from the image. This is now tested to run properly with the charm under development.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ghislainbourgeois ghislainbourgeois requested a review from a team as a code owner September 5, 2024 22:07
@ghislainbourgeois ghislainbourgeois merged commit 977c4a2 into main Sep 6, 2024
6 checks passed
@ghislainbourgeois ghislainbourgeois deleted the fix-include-ue branch September 6, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriciareinoso patriciareinoso patriciareinoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghislainbourgeois @patriciareinoso