Skip to content

Conversation

@dstathis
Copy link
Contributor

Issue

canonical/traefik-k8s-operator#491

Solution

We need to use a new method that returns the chain in the reverse order.

Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right, but I'd add a chonky comment to explain why we're using this method specifically, for when we forget about this.

@PietroPasotti
Copy link
Contributor

(also, it'd be handy to have a regression integration test for this?)

@MichaelThamm
Copy link

MichaelThamm commented Jun 27, 2025

Looks right, but I'd add a chonky comment to explain why we're using this method specifically, for when we forget about this.

This method is just the updated version of the original. Not really sure we need a chunky block comment since its doing the same thing, just in the right way.

@dstathis did you test this with SSC latest revision? We had to pin to SSC rev308 with this regression.

@dstathis dstathis merged commit 3657fcb into main Jun 27, 2025
18 checks passed
@dstathis dstathis deleted the fix-ordering branch June 27, 2025 12:39
@dstathis
Copy link
Contributor Author

Looks right, but I'd add a chonky comment to explain why we're using this method specifically, for when we forget about this.

This method is just the updated version of the original. Not really sure we need a chunky block comment since its doing the same thing, just in the right way.

@dstathis did you test this with SSC latest revision? We had to pin to SSC rev308 with this regression.

Yup tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants